Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete and clarify type parameters for text selector #24715

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

steverep
Copy link
Member

@steverep steverep commented Oct 27, 2022

Proposed change

  • Documents newly supported autocomplete parameter for text selector
  • Alters documentation of type parameter to better clarify usage consistent with autocomplete
  • Some spelling fixes
  • Some fixes for bad "is will" grammar

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@steverep steverep requested a review from zxdavb as a code owner October 27, 2022 19:23
@home-assistant home-assistant bot added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Oct 27, 2022
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@steverep steverep force-pushed the autocomplete-text-selector branch from a0a62e0 to e312f68 Compare October 27, 2022 19:30
@steverep steverep force-pushed the autocomplete-text-selector branch from e312f68 to 418e512 Compare October 27, 2022 19:51
@steverep steverep changed the title Autocomplete text selector Add autocomplete and clarify type parameters for text selector Oct 27, 2022
@steverep steverep force-pushed the autocomplete-text-selector branch from 418e512 to 08ea2c6 Compare October 27, 2022 20:31
@steverep steverep removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Oct 27, 2022
@steverep steverep force-pushed the autocomplete-text-selector branch from 08ea2c6 to 529369d Compare October 27, 2022 20:51
@home-assistant home-assistant bot added the has-parent This PR has a parent PR in a other repo label Oct 27, 2022
@steverep steverep removed the in-progress This PR/Issue is currently being worked on label Oct 29, 2022
bdraco
bdraco previously approved these changes Nov 15, 2022
@bdraco bdraco added the parent-merged The parent PR has been merged already label Nov 15, 2022
source/_docs/blueprint/selectors.markdown Outdated Show resolved Hide resolved
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Nov 15, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @steverep 👍

@frenck frenck merged commit 022c835 into next Nov 15, 2022
@frenck frenck deleted the autocomplete-text-selector branch November 15, 2022 19:44
@home-assistant home-assistant bot removed parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Nov 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! hacktoberfest-accepted has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants