-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] 0.18.x - Apply QueryAsset
splitting fix
#9160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kilo59
changed the title
[BUGFIX] 0.18.x - Apply
[BUGFIX] 0.18.x - Apply Dec 22, 2023
QuerAsset
splitting fixQueryAsset
splitting fix
billdirks
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 22, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 22, 2023
This was referenced Jan 3, 2024
This was referenced Jan 10, 2024
Merged
4 tasks
This was referenced Feb 1, 2024
4 tasks
This was referenced Feb 27, 2024
This was referenced Mar 12, 2024
Merged
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR See below was applying the
create_temp_table
fix that was already in0.18.x
but additionally solved the problem of splitters not being respected.QueryAsset
works withcreate_temp_table=False
#9150