Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] 0.18.x - Apply QueryAsset splitting fix #9160

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Dec 22, 2023

The PR See below was applying the create_temp_table fix that was already in 0.18.x but additionally solved the problem of splitters not being respected.

@Kilo59 Kilo59 changed the title [BUGFIX] 0.18.x - Apply QuerAsset splitting fix [BUGFIX] 0.18.x - Apply QueryAsset splitting fix Dec 22, 2023
@ghost
Copy link

ghost commented Dec 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 self-assigned this Dec 22, 2023
@Kilo59 Kilo59 marked this pull request as ready for review December 22, 2023 00:26
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kilo59 Kilo59 added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@Kilo59 Kilo59 added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@Kilo59 Kilo59 added this pull request to the merge queue Dec 22, 2023
Merged via the queue into 0.18.x with commit 8c5330e Dec 22, 2023
66 of 84 checks passed
@Kilo59 Kilo59 deleted the b/_/18_x_query_asset_splitter_cp branch December 22, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants