Properly default auth's storage config #48247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
changed the title
zmb3
added
the
no-changelog
marcoandredinis
approved these changes
Nov 1, 2024
smallinsky
approved these changes
Nov 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from flyinghermit
zmb3
force-pushed
the
zmb3/datadir
branch
2 times, most recently
from
8c03c14 to
de7cf64
Compare
Most of our tests override cfg.DataDir, but auth's storage config still uses a hard-coded /var/lib/teleport for backend state. Instead of fixing this in a bunch of tests, we stop defaulting to /var/lib/teleport and set the storage dir only after we know what the configured data dir is.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 1, 2024
This was referenced Dec 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run
TestDynamicClientReuselocally and noticed an error trying to write to/var/lib/teleport, which is unexpected since the test sets the data dir to a temp directory.It turns out that most of our tests override the datadir, but fail to also update the auth's storage config.
Instead of fixing this in a bunch of tests, stop defaulting auth storage to a hard-coded
/var/lib/teleportand instead set the default after we know what the configured data dir is supposed to be.