Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestSSH flakiness #41935

Closed
nklaassen opened this issue May 23, 2024 · 5 comments
Closed

TestSSH flakiness #41935

nklaassen opened this issue May 23, 2024 · 5 comments
Labels
flaky tests

Comments

@nklaassen
Copy link
Contributor

Failure

Link(s) to logs

Relevant snippet

=== Failed
=== FAIL: tool/tsh/common TestSSH (22.27s)

Not much to find in the logs, all subtests seem to pass, I suspect a failure in a t.Cleanup
@zmb3
Copy link
Collaborator

zmb3 commented May 23, 2024

https://github.com/gravitational/teleport/actions/runs/9210993262/job/25339294558

@zmb3
Copy link
Collaborator

zmb3 commented May 24, 2024

https://github.com/gravitational/teleport/actions/runs/9224882604/job/25381111253

zmb3 added a commit that referenced this issue May 24, 2024
@zmb3
Disable disk-based recording for TestSSH
cc484d3 
Updates #41935
@zmb3 zmb3 mentioned this issue May 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 24, 2024
@zmb3
Disable disk-based recording for TestSSH (#42013)
3dad702 
Updates #41935
github-actions bot pushed a commit that referenced this issue May 24, 2024
@zmb3
Disable disk-based recording for TestSSH
bb64461 
Updates #41935
github-actions bot pushed a commit that referenced this issue May 24, 2024
@zmb3
Disable disk-based recording for TestSSH
6a5d497 
Updates #41935
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@zmb3
Disable disk-based recording for TestSSH (#42018)
5713e3c 
Updates #41935
@zmb3
Copy link
Collaborator

zmb3 commented May 28, 2024

Let's assume that #42013 fixed it. Please reopen this if you see another failure.

@zmb3 zmb3 closed this as completed May 28, 2024
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@zmb3
Disable disk-based recording for TestSSH (#42019)
e7323f6 
Updates #41935
@ravicious
Copy link
Member

ravicious commented Jun 3, 2024 •
edited
Loading

Current v16: https://github.com/gravitational/teleport/actions/runs/9347402654/job/25724333805#step:6:1584

Same error with a failure somewhere in a cleanup.

=== FAIL: tool/tsh/common TestSSH (22.34s)

Edit: This seems to be an issue with general cleanup code, not this test specifically.

@ravicious ravicious reopened this Jun 3, 2024
@rosstimothy
Copy link
Contributor

I suspect this was fixed by #48247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ravicious @zmb3 @nklaassen @rosstimothy