TestTSHConfigConnectWithOpenSSHClient flakiness

[nklaassen]

Failure

saw this fail off of branch/v10

CI Logs

• https://console.cloud.google.com/cloud-build/builds/8cd306c3-13b3-454f-bbb3-f3ccf70f797b?project=ci-account
• https://console.cloud.google.com/cloud-build/builds;region=us-west1/d926b469-8a79-41a0-891f-bcb54f9b8ae1;step=0?project=ci-account

Relevant snippet

proxy_test.go:590: failed to find AuthAttemptFailureCode event
    --- FAIL: TestTSHConfigConnectWithOpenSSHClient/node_recording_mode_with_TLS_routing_enabled (6.28s)

[ibeckermayer]

Another https://console.cloud.google.com/cloud-build/builds/28de0bd2-96c0-40a9-a893-b0b77c54d03c?project=ci-account

[ibeckermayer]

https://console.cloud.google.com/cloud-build/builds;region=us-west1/147bcb2c-ebb0-428a-bac1-617511af5f4d?project=ci-account

[zmb3]

No recent occurrences - closing.

[Tener]

https://github.com/gravitational/teleport/actions/runs/5289793085/jobs/9573155894#step:6:1239

ERROR: access denied to invalidUser connecting to localhost:24915

    testing.go:1206: TempDir RemoveAll cleanup: unlinkat /tmp/TestTSHConfigConnectWithOpenSSHClientnode_recording_mode_with_TLS_routing_disabled2058613825/001/log/upload/streaming/default: directory not empty
--- FAIL: TestTSHConfigConnectWithOpenSSHClient/node_recording_mode_with_TLS_routing_disabled (3.93s)

[zmb3]

https://github.com/gravitational/teleport/actions/runs/6499821889/job/17653962947

Same tmpdir problem that @Tener reported above.

[zmb3]

https://github.com/gravitational/teleport/actions/runs/6536740019/job/17749096397

[ptgott]

Another: https://github.com/gravitational/teleport/actions/runs/6631005136/job/18013594849#step:6:1471

[espadolini]

I got another spurious failure but I'm not sure if my change is to blame.

https://github.com/gravitational/teleport/actions/runs/7119289706/job/19384058844?pr=34396#step:6:1681

[ravicious]

Got in on master as well, should we reopen this?

https://github.com/gravitational/teleport/actions/runs/7180029933/job/19551450972#step:6:1896

    proxy_test.go:1110: failed to find AuthAttemptFailureCode event (0/7 events matched)

[zmb3]

https://github.com/gravitational/teleport/actions/runs/7249997178/job/19749201015

hello
    proxy_test.go:1110: failed to find AuthAttemptFailureCode event (0/9 events matched)

=== FAIL: tool/tsh/common TestTSHConfigConnectWithOpenSSHClient (24.59s)

[zmb3]

@Joerger can you take another look?

[zmb3]

Looks like this one is failing again (this time due to session recording): https://github.com/gravitational/teleport/actions/runs/9369138772/job/25792871538?pr=42365

    testing.go:1225: TempDir RemoveAll cleanup: unlinkat /tmp/TestTSHConfigConnectWithOpenSSHClientproxy_recording_mode_with_TLS_routing_disabled3047589291/001/log/records/multi/12094a99-7547-401c-8dae-13e6884ce7ce/fd839c3d-8b6e-4a68-b341-b5b597428014: directory not empty

=== FAIL: tool/tsh/common TestTSHConfigConnectWithOpenSSHClient (22.54s)

[rosstimothy]

I suspect that that TempDir problems were resolved by #48247.