Fix flaky test TestTSHConfigConnectWithOpenSSHClient
#35861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/sm
tsh
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
added
the
no-changelog
greedy52
approved these changes
Dec 18, 2023
zmb3
requested changes
Dec 19, 2023
tigrato
approved these changes
Dec 20, 2023
zmb3
reviewed
Dec 20, 2023
tool/tsh/common/proxy_test.go
Outdated
| assert.NoError(t, err) | ||
|
|
||
| for _, e := range es { | ||
| if e.GetCode() == events.AuthAttemptFailureCode && e.(*apievents.AuthAttempt).Login == nodeLogin { |
There was a problem hiding this comment.
The semantics here are slightly different than what we had before - is this intentional?
Before, if there was an AuthAttempt failure, the test would fail if the login was incorrect.
After, we just ignore these events if the login is incorrect.
zmb3
approved these changes
Dec 23, 2023
zmb3
deleted the
joerger/fix-flaky-test-TestTSHConfigConnectWithOpenSSHClient
branch
nklaassen
pushed a commit
that referenced
this pull request
Jan 4, 2024
Backport #35861 to branch/v12
|
I went ahead and opened the backports since Brian is still OOO and I just hit this on branch/v14 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
Backport #35861 to branch/v12 Co-authored-by: Brian Joerger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13623