Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test TestTSHConfigConnectWithOpenSSHClient #33556

Merged

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Oct 17, 2023

Fixes the same issue reported by other test flakes like #19878

Fixes #13623

@github-actions github-actions bot requested review from hugoShaka and tcsc October 17, 2023 00:57
@github-actions github-actions bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Oct 17, 2023
@Joerger
Copy link
Contributor Author

Joerger commented Oct 17, 2023

@zmb3 @r0mant Can you exclude the flaky test detector (times out)?

@zmb3
Copy link
Collaborator

zmb3 commented Oct 17, 2023

/excludeflake TestTSHConfigConnectWithOpenSSHClient

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tcsc October 23, 2023 22:38
@zmb3 zmb3 added this pull request to the merge queue Oct 24, 2023
@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label Oct 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2023
@Joerger Joerger added this pull request to the merge queue Oct 24, 2023
Merged via the queue into master with commit 7b66ac7 Oct 24, 2023
29 checks passed
@Joerger Joerger deleted the joerger/flaky-test-TestTSHConfigConnectWithOpenSSHClient branch October 24, 2023 19:19
@public-teleport-github-review-bot

@Joerger See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v13 backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestTSHConfigConnectWithOpenSSHClient flakiness
3 participants