chore: exclude grpc-android from bom validation #6189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
reviewed
Sep 19, 2023
| builder.append(" <version>").append(version).append("</version>\n"); | ||
| builder.append(" <type>pom</type>\n"); | ||
| builder.append(" <scope>import</scope>\n"); | ||
| builder.append(" <exclusions>\n"); |
There was a problem hiding this comment.
I don't think dependencyManagement's "import" type can take exclusion.
If it works, can you add your observation when you run this with the latest grpc-bom?
There was a problem hiding this comment.
You're right. The exclusion compiles but it doesn't work for a dependencyManagement import. Tried replicating the GA job's behavior locally and observed that it creates a tmp/validation-bom/pom.xml which includes the following dependencies:
There was a problem hiding this comment.
Verified that with changes in f965cf7, the tmp/validation-bom/pom.xml doesn't contain grpc-android`
|
First, ensure you know how to run the class. |
product-auto-label
bot
added
size: xs
suztomo
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.