Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude grpc-android from bom validation #6189

Merged
merged 5 commits into from
Sep 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ private static String calculateDependenciesSection(Bom bom) {
continue;
}

// Skipping grpc-android as it is not used by Google Cloud Client Libraries for Java. Checking
// for availability of
// this unused artifact on Maven Central has caused BOM validation check to fail in the past.
// See
// https://github.com/googleapis/sdk-platform-java/pull/1989#issuecomment-1724039670
if ("grpc-android".equals(managedDependency.getArtifactId())) {
continue;
}

builder.append(" <dependency>\n");
builder
.append(" <groupId>")
Expand Down