Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip grpc-android during bom validation #2351

Closed
wants to merge 2 commits into from

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Sep 18, 2023

Bom.readBom(bomPath); is called in CreateBomCanaryProject which creates a canary project (a sample directory with a pom) for BOM validation.

The validation of grpc-android first failed in googleapis/sdk-platform-java#1989 with the following error message even though grpc-android is available at https://repo1.maven.org/maven2/io/grpc/grpc-android/1.58.0/grpc-android-1.58.0.aar :

Error:  Failed to execute goal on project bom-validation-canary-project: Could not resolve dependencies for project com.google.cloud:bom-validation-canary-project:jar:0.0.1-SNAPSHOT: The following artifacts could not be resolved: io.grpc:grpc-android:jar:1.58.0, io.grpc:grpc-binder:jar:1.58.0, androidx.annotation:annotation:jar:1.6.0, androidx.core:core:jar:1.10.1, androidx.lifecycle:lifecycle-common:jar:2.6.1, io.grpc:grpc-cronet:jar:1.58.0, org.chromium.net:cronet-api:jar:108.5359.79: Could not find artifact io.grpc:grpc-android:jar:1.58.0 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

Since grpc-android is not used in the java client libraries, it's existence doesn't have to be verified.

@mpeddada1 mpeddada1 requested a review from suztomo September 18, 2023 22:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@suztomo
Copy link
Contributor

suztomo commented Sep 18, 2023

@mpeddada1
Copy link
Contributor Author

Closing this PR in favor of googleapis/java-cloud-bom#6189

@mpeddada1 mpeddada1 closed this Sep 18, 2023
@mpeddada1 mpeddada1 deleted the exclude-grpc-android branch September 18, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants