Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip grpc-android during bom validation #2351

Closed
wants to merge 2 commits into from
Closed

chore: skip grpc-android during bom validation #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6ffe2
chore: skip grpc-android during bom validation
mpeddada1 Sep 18, 2023
6cfb359
remove unused import
mpeddada1 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions dependencies/src/main/java/com/google/cloud/tools/opensource/dependencies/Bom.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@ public static boolean shouldSkipBomMember(Artifact artifact) {
return true;
}

// Skipping grpc-android as it is not used by Google Cloud Client Libraries for Java. Checking
// for availability of
// this unused artifact on Maven Central has caused BOM validation check to fail in the past. See
// https://github.com/googleapis/sdk-platform-java/pull/1989#issuecomment-1724039670
if ("grpc-android".equals(artifact.getArtifactId())) {
return true;
}

return false;
}
}
6 changes: 6 additions & 0 deletions dependencies/src/test/java/com/google/cloud/tools/opensource/dependencies/BomTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.nio.file.Path;
import java.util.List;
import org.eclipse.aether.artifact.Artifact;
import org.eclipse.aether.artifact.DefaultArtifact;
import org.eclipse.aether.resolution.ArtifactDescriptorException;
import org.junit.Assert;
import org.junit.Test;
Expand Down Expand Up @@ -77,4 +78,9 @@ public void testReadBom_path()
.inOrder();
}

@Test
public void testIsSkipped_grpcAndroid() {
Artifact artifact = new DefaultArtifact("io.grpc:grpc-android:jar:1.58.0");
Truth.assertThat(Bom.shouldSkipBomMember(artifact)).isTrue();
}
}