Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrontEnd : CSS : Transition and transformation (D) - Part 2 (only contains Transitions) #2606

Merged

Conversation

RC2208
Copy link
Contributor

@RC2208 RC2208 commented Sep 25, 2021


Description 📜

CSS transitions documentation and code. This my 2nd PR on the issue.
Fixes # #1061


Type of change 📝

  • Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

  • Frontend Dev HTML/CSS/JS

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸


@keywordlabeler keywordlabeler bot added documentation Improvements or additions to documentation Frontend Dev HTML/CSS/JS labels Sep 25, 2021
@RC2208
Copy link
Contributor Author

RC2208 commented Sep 27, 2021

#2295

Here's the pr of part 1 of the issue please merge both

Copy link
Collaborator

@code-reaper08 code-reaper08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a review, please look into it, add syntax specific codeblocks to all code examples.

## Selecting all properties <br>
transition-property takes a special value: `all`. When all is specified, all CSS transition properties will start move.

css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have the codes in code blocks like

div {
  transition: width 2s, height 4s;
}


Code For different transition prpoerties: <br>
css
div {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeblocks here too

#div4 {transition-timing-function: ease-out;}
#div5 {transition-timing-function: ease-in-out;}

div:hover {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeblocks here

@RC2208
Copy link
Contributor Author

RC2208 commented Sep 29, 2021

I've left a review, please look into it, add syntax specific codeblocks to all code examples.

Thank you , I forgot to add them. Added them now! @code-reaper08

Copy link
Collaborator

@code-reaper08 code-reaper08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2024-SANDHYA have a look here, this is the second part of #2295

@2024-SANDHYA
Copy link
Collaborator

@2024-SANDHYA have a look here, this is the second part of #2295

Why two parts @RC2208 ? You can include it in one file itself, just divide it into two parts that's it. What do you say @code-reaper08 ?

@RC2208
Copy link
Contributor Author

RC2208 commented Sep 30, 2021

@2024-SANDHYA have a look here, this is the second part of #2295

Why two parts @RC2208 ? You can include it in one file itself, just divide it into two parts that's it. What do you say @code-reaper08 ?

Hey!I asked 3-4 supervisors and the program manager if I could make 2 seperate PR's since the documentation for both were very long. They allowed it so it can count as 2 PR's for contribution @2024-SANDHYA

@2024-SANDHYA
Copy link
Collaborator

@2024-SANDHYA have a look here, this is the second part of #2295

Why two parts @RC2208 ? You can include it in one file itself, just divide it into two parts that's it. What do you say @code-reaper08 ?

Hey!I asked 3-4 supervisors and the program manager if I could make 2 seperate PR's since the documentation for both were very long. They allowed it so it can count as 2 PR's for contribution @2024-SANDHYA

Ya that too is accepted but ,okay as you feel you can do that after all, it's open-source, can't restrict you & your creativity ☺️

@RC2208
Copy link
Contributor Author

RC2208 commented Sep 30, 2021

@2024-SANDHYA have a look here, this is the second part of #2295

Why two parts @RC2208 ? You can include it in one file itself, just divide it into two parts that's it. What do you say @code-reaper08 ?

Hey!I asked 3-4 supervisors and the program manager if I could make 2 seperate PR's since the documentation for both were very long. They allowed it so it can count as 2 PR's for contribution @2024-SANDHYA

Ya that too is accepted but ,okay as you feel you can do that after all, it's open-source, can't restrict you & your creativity ☺️

Okay 😁 thank you! Can it be merged now?

@code-reaper08 code-reaper08 merged commit e21357f into girlscript:Frontend_Web_Development_HTML_CSS_JS Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Frontend Dev HTML/CSS/JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants