Allow to set IKSolver parameters #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @MarcoMagriDev I'll rebase this on the current ROS2 branch and see how to merge it. We dropped most of the ROS2 version-dependend distinctions. |
…`/`) so that they can be correctly set from yaml params file
stefanscherzinger
force-pushed
the
fix-ik-solver-params
branch
from
ebb4708
to
7b19e3b
Compare
That's no longer needed.
Also use explicit hashes for pre-commit hooks. That's a little safer.
stefanscherzinger
merged commit f8aad77
into
fzi-forschungszentrum-informatik:ros2
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address the impossibility to set parameters of IK solvers from ROS2 yaml params file as suggested here.
To avoid params redeclarations an
auto_declareprotected method has been defined for the IKSolver base class(fix similar to the one proposed in #129)