If no command is given show help text; and instructions on sub-help. Include a dev quick start in the README #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Include a dev quick start in the README
ecooper
approved these changes
Nov 22, 2024
| ``` | ||
| npm install | ||
| npm run build | ||
| ./src/user-entrypoint.mjs |
There was a problem hiding this comment.
You can use this without having a build so in this example...build isn't necessary. So depending on what your intent here is, you may need to change this.
There was a problem hiding this comment.
Tests require builds (b/c we assert things on the behavior of the prod bundle), so I think it's reasonable to include?
There was a problem hiding this comment.
i put this in to make sure your stuff wasn't roont.
Make sense?
Cause my stuff was roont.
There was a problem hiding this comment.
i'll add some comments so noone else brain freezes when they read it.
echo-bravo-yahoo
approved these changes
Nov 22, 2024
| @@ -40,7 +40,7 @@ describe("cli operations", function () { | |||
| }); | |||
|
|
|||
| // TODO: this doesn't work because turning on strict mode breaks parsing sub-commands. why? | |||
| it("should exit with a helpful message if a non-existant command is provided", async function () { | |||
| it("should exit with a helpful message if a non-existent command is provided", async function () { | |||
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6153
Problem
If no command is given we are showing some generic red text.
Solution
Instead just show help, and how to get more detailed help
Result
No weird errors shown.
Out of scope
We should do the same thing for missing sub commands.
Tracking here: https://faunadb.atlassian.net/browse/FE-6154
Testing
Ran the suite.