Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login test fix #492

Merged
merged 5 commits into from
Dec 9, 2024
Merged

login test fix #492

merged 5 commits into from
Dec 9, 2024

Conversation

mwilde345
Copy link
Member

@mwilde345 mwilde345 commented Dec 6, 2024 •
edited
Loading

Problem

  • Never updated login tests after changing up the creds middleware

Solution

  • Made the tests work w/ new stuff.

@mwilde345 mwilde345 changed the base branch from main to v3 December 6, 2024 22:41
@mwilde345 mwilde345 requested a review from a team as a code owner December 6, 2024 22:41
@mwilde345 mwilde345 merged commit fabed04 into v3 Dec 9, 2024
4 checks passed
@mwilde345 mwilde345 deleted the login-test-fix branch December 9, 2024 21:23
@mwilde345 mwilde345 mentioned this pull request Dec 10, 2024
Closed
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
Closed
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryfauna henryfauna henryfauna approved these changes

@ecooper ecooper ecooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwilde345 @ecooper @henryfauna