-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If no command is given show help text; and instructions on sub-help. Include a dev quick start in the README #429
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ describe("cli operations", function () { | |
}); | ||
|
||
// TODO: this doesn't work because turning on strict mode breaks parsing sub-commands. why? | ||
it("should exit with a helpful message if a non-existant command is provided", async function () { | ||
it("should exit with a helpful message if a non-existent command is provided", async function () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oopsie |
||
const logger = container.resolve("logger"); | ||
|
||
// this command does not exist | ||
|
@@ -56,6 +56,22 @@ describe("cli operations", function () { | |
expect(container.resolve("parseYargs")).to.have.been.calledOnce; | ||
}); | ||
|
||
it("should exit with a helpful message if no command is provided", async function () { | ||
const logger = container.resolve("logger"); | ||
|
||
// no input | ||
try { | ||
await run("", container); | ||
} catch (e) {} | ||
|
||
expect(logger.stdout).to.not.be.called; | ||
const message = `${chalk.reset(await builtYargs.getHelp())}\n\n${chalk.reset( | ||
"Use 'fauna <command> --help' for more information about a command.", | ||
)}`; | ||
expect(logger.stderr).to.have.been.calledWith(message); | ||
expect(container.resolve("parseYargs")).to.have.been.calledOnce; | ||
}); | ||
|
||
it("should exit with a helpful message if the handler throws", async function () { | ||
const logger = container.resolve("logger"); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use this without having a build so in this example...build isn't necessary. So depending on what your intent here is, you may need to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests require builds (b/c we assert things on the behavior of the prod bundle), so I think it's reasonable to include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i put this in to make sure your stuff wasn't roont.
Make sense?
Cause my stuff was roont.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll add some comments so noone else brain freezes when they read it.