Add Github action for testing #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo-bravo-yahoo
force-pushed
the
echo-bravo-yahoo-patch-1
branch
from
96e1244 to
b873b5c
Compare
.github/workflows/node.js.yml
Outdated
Comment on lines
7
to
10
| push: | ||
| branches: [ "main", "v3" ] | ||
| pull_request: | ||
| branches: [ "main", "v3" ] |
There was a problem hiding this comment.
the "v3" branch inclusion is temporary while we're working on the next version of the CLI
There was a problem hiding this comment.
Do we want to run this and circle on main while we're working out of v3?
There was a problem hiding this comment.
good point - let me turn it off for main
This reverts commit 60731d7. we send a webhook to circleCI and report failure regardless of whether or not there's a config file.
ecooper
approved these changes
Oct 22, 2024
.github/workflows/node.js.yml
Outdated
Comment on lines
7
to
10
| push: | ||
| branches: [ "main", "v3" ] | ||
| pull_request: | ||
| branches: [ "main", "v3" ] |
There was a problem hiding this comment.
Do we want to run this and circle on main while we're working out of v3?
Merged
Closed
This was referenced Dec 2, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-6016
Problem
We currently do build/test in CircleCI, out of reach of any open source contributors.
Solution
Test in a github action.
Result
Contributors have a better experience w/viewing test results.