Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist secrets #417

Merged
merged 18 commits into from
Nov 20, 2024
Merged

persist secrets #417

merged 18 commits into from
Nov 20, 2024

Conversation

mwilde345
Copy link
Member

@mwilde345 mwilde345 commented Nov 19, 2024

Ticket(s): FE-6132

Problem

  • No tests to validate the behavior of the authNZ middleware

Solution

  • add them.
    • Includes a combination of stubbing out some class methods (e.g. AccountKey.get) and also stubbing out the 'edge' (fetch and fs)

Result

  • We know what functionality the authNZ middleware provides

Testing

Screenshot 2024-11-20 at 1 17 16 PM

@mwilde345 mwilde345 changed the base branch from main to v3 November 19, 2024 17:36
@mwilde345 mwilde345 marked this pull request as ready for review November 20, 2024 18:17
@mwilde345 mwilde345 requested review from echo-bravo-yahoo and a team November 20, 2024 18:36
package.json Outdated Show resolved Hide resolved
src/cli.mjs Show resolved Hide resolved
test/helpers.mjs Show resolved Hide resolved
test/authNZ.mjs Outdated Show resolved Hide resolved
test/authNZ.mjs Outdated Show resolved Hide resolved
test/authNZ.mjs Show resolved Hide resolved
test/authNZ.mjs Outdated Show resolved Hide resolved
@mwilde345 mwilde345 merged commit 672c6d5 into v3 Nov 20, 2024
4 checks passed
@mwilde345 mwilde345 deleted the persist-secrets branch November 20, 2024 22:43
@cleve-fauna cleve-fauna mentioned this pull request Nov 22, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 5, 2024
This was referenced Dec 6, 2024
@cleve-fauna cleve-fauna mentioned this pull request Dec 13, 2024
@mwilde345 mwilde345 mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants