Adopt eslint-plugin-unicorn
#1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start using `eslint-plugin-unicorn` to enforce opinionated stylistic consistency. All rules are explicitly configured to ensure the code follows the standard of this project. This commit includes "trivial" refactoring in scope of the rules. Most rules are enabled as is. Some rules are disabled for various reasons: - `import-style`: limited value while hard to configure. Default config not desired. - `no-nested-ternary`: conflicts with Prettier. - `no-null`: non-trivial to refactor but intend adopt based on the motivation provided in the rule description. - `prefer-spread`: imperfect rule that conflicts with this code base. Open to reconsider later. - `prefer-string-raw`: I'm okay with escaping and am concerned about performance impacts of using `String.raw`. - `prefer-ternary`: too situational to lint for in my opinion. Open to reconsider later. - `prevent-abbreviations`: mainly don't have a solution for the "args" abbreviation. Open to reconsider later.
ericcornelissen
added
dependencies
ericcornelissen
commented
Dec 15, 2024
Refactor the ESLint configuration primarily with the goal of enforcing a consistent style on all JavaScript in the code base to the extend possible. This change did uncover some new problems with the newly introduced unicorn plugin: - `consistent-destructuring`: like `prefer-ternary`: too situational to lint for in my opinion. Open to reconsider later. - `number-literal-case`: conflicts with Prettier Lastly, the `unicorn/prefer-string-replace-all` rule has also been disabled because it is not compatible with Node.js v14.18.0, which is still supported by this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Start using
eslint-plugin-unicornto enforce opinionated stylistic consistency. All rules are explicitly configured to ensure the code follows the standard of this project.