Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer String#replaceAll over String#replace #1814

Open
ericcornelissen opened this issue Dec 15, 2024 · 0 comments
Open

Prefer String#replaceAll over String#replace #1814

ericcornelissen opened this issue Dec 15, 2024 · 0 comments
Labels
breaking change Changes that are not backwards compatible pending This cannot be worked on yet refactor Changes existing code without changing functionality

Comments

@ericcornelissen
Copy link
Owner

Caused by #1812 (comment)

Summary

Update the code base to move to using String.prototype.replaceAll instead of String.prototype.replace following the eslint-plugin-unicorn rule string-prefer-replace-all and enforce this using ESLint.

This is currently pending because String.prototype.replaceAll was not yet introduced in Node.js v14.18.0, which is still supported by this package.

@ericcornelissen ericcornelissen added breaking change Changes that are not backwards compatible pending This cannot be worked on yet labels Dec 15, 2024
@ericcornelissen ericcornelissen added the refactor Changes existing code without changing functionality label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that are not backwards compatible pending This cannot be worked on yet refactor Changes existing code without changing functionality
Projects
None yet
Development

No branches or pull requests

1 participant