Configure ESLint's own rules #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the ESLint config to enable and configure most of its own rules. This iteration on the configuration is mostly focussed on enabling rules the code base already complies with or can trivially comply with to ensure consistency going forward. Any rule that has been disabled may be reconsidered in the future. Note that rules marked as "deprecated" by ESLint were not included here.
ericcornelissen
commented
Dec 15, 2024
Comment on lines
-38
to
+42
| "jsdoc/check-examples": ["off"], // TODO: enable & configure when possible | ||
| "jsdoc/check-examples": ["off"], |
There was a problem hiding this comment.
Re-evaluating this TODO as part of this PR.
There was a problem hiding this comment.
The rule still does not work as of jsdoc/[email protected] so I'll leave it disabled.
I won't create an issue to enable this because I could not find a suitable way to track when this can be enabled again.
ericcornelissen
commented
Dec 15, 2024
ericcornelissen
commented
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1803, #1812
Summary
Update the ESLint config to enable and configure most of its own rules. This iteration on the configuration is mostly focused on enabling rules the code base already complies with or can trivially comply with to ensure consistency going forward. Any rule that has been disabled may be reconsidered in the future.