Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #1430

Merged
merged 18 commits into from
Sep 19, 2024
Merged

Fix docs #1430

merged 18 commits into from
Sep 19, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Sep 17, 2024

Fix docs

@Mallets Mallets added the api sync Synchronize API with other bindings label Sep 17, 2024
Copy link

PR missing one of the required labels: {'documentation', 'breaking-change', 'internal', 'bug', 'dependencies', 'enhancement', 'new feature'}

Copy link

PR missing one of the required labels: {'new feature', 'internal', 'dependencies', 'documentation', 'enhancement', 'breaking-change', 'bug'}

@Mallets Mallets added internal Changes not included in the changelog and removed api sync Synchronize API with other bindings labels Sep 17, 2024
@Mallets Mallets marked this pull request as ready for review September 18, 2024 11:45
@Mallets Mallets requested a review from fuzzypixelz September 18, 2024 11:45
Copy link
Member

@fuzzypixelz fuzzypixelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stick with the third person pronoun as is done in std and most Rust crates.

Here's an example: https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#method.push

@Mallets
Copy link
Member Author

Mallets commented Sep 18, 2024

@fuzzypixelz Suggestions applied!

@Mallets Mallets merged commit 4fc61e6 into main Sep 19, 2024
21 of 24 checks passed
@Mallets Mallets deleted the fix/docs branch September 19, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants