Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of public zenoh items #1304

Closed
fuzzypixelz opened this issue Aug 9, 2024 · 2 comments
Closed

Review of public zenoh items #1304

fuzzypixelz opened this issue Aug 9, 2024 · 2 comments
Labels

Comments

@fuzzypixelz
Copy link
Member

fuzzypixelz commented Aug 9, 2024

Quickly skimming https://docs.rs/zenoh/1.0.0-alpha.6/zenoh/all.html, one can see that the presence of some items may be problematic:

Duplicate definitions

zenoh-keyexpr::keyexpr_tree re-exports

zenoh-protocol re-exports

Leaked implementation details

Inconsistency in naming constants

Internal utilities

The above list may be non-exhaustive.

To reproduce

N/A

System info

  • ref: 1.0.0-alpha.6
@fuzzypixelz
Copy link
Member Author

Resolved in #1462, #1461, #1457, #1441, #1447, #1437, #1434, #1430, #1425, #1423, #1419 and 4e058de.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants