-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide zenoh_config
internals
#1419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
force-pushed
the
internal-config
branch
2 times, most recently
from
September 13, 2024 15:55
194d58b
to
034dad8
Compare
fuzzypixelz
added
bug
Something isn't working
breaking-change
Indicates that the issue implies a breaking change (be it at compile time or at runtime)
labels
Sep 13, 2024
fuzzypixelz
force-pushed
the
internal-config
branch
from
September 16, 2024 08:04
6037e53
to
93fdbdf
Compare
fuzzypixelz
changed the title
Make configuration structure
Hide Sep 16, 2024
internal
zenoh_config
internals
fuzzypixelz
force-pushed
the
internal-config
branch
3 times, most recently
from
September 16, 2024 09:01
fd76a91
to
e23527b
Compare
fuzzypixelz
force-pushed
the
internal-config
branch
5 times, most recently
from
September 16, 2024 12:40
3b9d8fb
to
984f955
Compare
fuzzypixelz
force-pushed
the
internal-config
branch
3 times, most recently
from
September 16, 2024 13:15
ae0bf38
to
95b9d1e
Compare
fuzzypixelz
force-pushed
the
internal-config
branch
from
September 16, 2024 16:08
b08afba
to
bf67421
Compare
fuzzypixelz
force-pushed
the
internal-config
branch
from
September 17, 2024 08:21
30df65b
to
69fdad3
Compare
Mallets
reviewed
Sep 17, 2024
Mallets
reviewed
Sep 17, 2024
Mallets
reviewed
Sep 17, 2024
Mallets
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
Merged
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Indicates that the issue implies a breaking change (be it at compile time or at runtime)
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1417 and #1304 with the following changes:
zenoh::Config
withzenoh::config::Config
leavingzenoh_config::Config
unchanged.zenoh_config::Config
with the following public items:Default
,Debug
,Clone
andDefault
implsDeref<Target = InternalConfig>
andDerefMut<Target = InternalConfig>
impls withcfg(feature = "unstable_config")
]from_env
,from_file
,insert_json5
,get
andremove
zenoh::config
to the following public items:Config
InsertionError
LookupError
LookupGuard
WhatAmI
(forzenoh::scout
)WhatAmIMatcher
(forzenoh::scout
)Notifier
(forzenoh::Session::config
)Notification
(forzenoh::config::Notifier
)Notifier
to the zenoh crate with the following API:new
(not sure about this one)subscribe
notify
lock
remove
insert_json5
get
Older code using the
zenoh_config::Config
API will still compile provided that items such asModeDependentValue
are imported fromzenoh_config
.I believe the
Config
API changes is ready to be propagated to bindings. Here are CI runs to know what's going wrong: