Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs #1430

Merged
merged 18 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions zenoh/src/api/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ impl Reply {
}

#[zenoh_macros::unstable]
// @TODO: maybe return an `Option<EntityGlobalId>`?
//
/// Gets the id of the zenoh instance that answered this Reply.
pub fn replier_id(&self) -> Option<ZenohId> {
self.replier_id.map(Into::into)
Expand Down
7 changes: 3 additions & 4 deletions zenoh/src/api/queryable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ impl Query {
}
}

/// Sends a reply to this Query.
/// Sends a [`crate::sample::Sample`] of kind [`crate::sample::SampleKind::Put`] as a reply to this Query.
///
/// By default, queries only accept replies whose key expression intersects with the query's.
/// Unless the query has enabled disjoint replies (you can check this through [`Query::accepts_replies`]),
Expand Down Expand Up @@ -178,8 +178,7 @@ impl Query {
}
}

/// Sends a error reply to this Query.
///
/// Sends a [`crate::query::ReplyError`] as a reply to this Query.
#[inline(always)]
pub fn reply_err<IntoZBytes>(&self, payload: IntoZBytes) -> ReplyErrBuilder<'_>
where
Expand All @@ -191,7 +190,7 @@ impl Query {
}
}

/// Sends a delete reply to this Query.
/// Sends a [`crate::sample::Sample`] of kind [`crate::sample::SampleKind::Delete`] as a reply to this Query.
///
/// By default, queries only accept replies whose key expression intersects with the query's.
/// Unless the query has enabled disjoint replies (you can check this through [`Query::accepts_replies`]),
Expand Down