Bug: autocomplete pixels firing when Adding Bookmark #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2024
anikiki
changed the title
CrisBarreiro
approved these changes
Oct 21, 2024
15 tasks
anikiki
force-pushed
the
fix/ana/bug_autocomplete_pixels_firing_when_adding_bookmark
branch
from
77a9ff2 to
688b218
Compare
Task/Issue URL: https://app.asana.com/0/488551667048375/1208592488628219/f ### Description Fixed item deletion from suggestions. ### Steps to test this PR Test in Browser: - [x] Install from this branch - [x] Search for something, i.e. "dog food". - [x] Search for "dog". - [x] Long press and delete the "dog food" entry. Verify: - [x] That the keyboard is shown. - [x] That the autocomplete list is shifted up (So the position of the entry is visible). - [x] That the entry is deleted from the list. Test using the widget - [x] Install from this branch - [x] Add the widget. - [x] Search for something from the widget, i.e. "dog food". - [x] Search for "dog". - [x] Long press and delete the "dog food" entry. Verify: - [x] That the keyboard is shown. - [x] That the autocomplete list is shifted up (So the position of the entry is visible). - [x] That the entry is deleted from the list. ### NO UI changes
anikiki
merged commit f6acf55
into
feature/ana/android_migrate_auto_complete_to_flow_and_coroutines
4 of 5 checks passed
anikiki
deleted the
fix/ana/bug_autocomplete_pixels_firing_when_adding_bookmark
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208581391309609/f
Description
Fixed autocomplete flow and pixels.
Steps to test this PR
Steps to repro:
feature/ana/android_migrate_auto_complete_to_flow_and_coroutinesm_autocomplete_displayed_bookmark
m_autocomplete_displayed_switch_to_tab
Test the fix:
NO UI changes