Add translations for open tabs in search autosuggest #5065

anikiki · 2024-09-25T16:48:52Z

Task/Issue URL: https://app.asana.com/0/1200581511062568/1208400325419530/f

Description

Translations.

Steps to test this PR

Install from this branch.
Open a few tabs. E.g www.gardenersworld.com
Search for something that will match an open tab. E.g garden
Notice the "Switch to Tab · " text before the URL in the suggestion.

UI changes (Added Switch to Tab string)

Before	After

anikiki · 2024-09-25T16:49:12Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anikiki and the rest of your teammates on Graphite

CrisBarreiro

Looks good and works as expected!

Translate strings to values-ru

Translate strings to values-da Translate strings to values-cs

Translate strings to values-fr

Translate strings to values-lt

Translate strings to values-ro Translate strings to values-sk Translate strings to values-ru Translate strings to values-et Translate strings to values-fi Translate strings to values-sl Translate strings to values-nl Translate strings to values-hr Translate strings to values-hu Translate strings to values-sv Translate strings to values-da Translate strings to values-fr Translate strings to values-lt Translate strings to values-pt Translate strings to values-cs

Translate strings-autofill-impl to values-nl Translate strings-autofill-impl to values-it Translate strings-autofill-impl to values-ro Translate strings-autofill-impl to values-sk Translate strings-autofill-impl to values-sv Translate strings-autofill-impl to values-bg Translate strings-autofill-impl to values-fr Translate strings-autofill-impl to values-sl Translate strings-autofill-impl to values-lt Translate strings-autofill-impl to values-el Translate strings-autofill-impl to values-pt Translate strings-autofill-impl to values-et Translate strings-autofill-impl to values-nb Translate strings-autofill-impl to values-de Translate strings-autofill-impl to values-ru Translate strings-autofill-impl to values-tr Translate strings-autofill-impl to values-hu Translate strings-autofill-impl to values-fi Translate strings-autofill-impl to values-lv Translate strings-autofill-impl to values-pl Translate strings-autofill-impl to values-da Translate strings-autofill-impl to values-es Translate strings-autofill-impl to values-cs

Translate strings-duckplayer to values-fi Translate strings-duckplayer to values-pl Translate strings-duckplayer to values-sl Translate strings-duckplayer to values-da Translate strings-duckplayer to values-de Translate strings-duckplayer to values-it Translate strings-duckplayer to values-es Translate strings-duckplayer to values-lt Translate strings-duckplayer to values-et Translate strings-duckplayer to values-sv Translate strings-duckplayer to values-tr Translate strings-duckplayer to values-pt Translate strings-duckplayer to values-lv Translate strings-duckplayer to values-hu Translate strings-duckplayer to values-fr Translate strings-duckplayer to values-hr Translate strings-duckplayer to values-ru Translate strings-duckplayer to values-nb Translate strings-duckplayer to values-sk Translate strings-duckplayer to values-bg Translate strings-duckplayer to values-ro Translate strings-duckplayer to values-cs Translate strings-duckplayer to values-nl

Task/Issue URL: https://app.asana.com/0/72649045549333/1208287265878043/f ### Description Added feature flag for switch to tab. Removed unneeded quick insert icons. Formatted urls in autosuggest. Added dividers between autosuggest sections. Updated color on switch to tab icon. ### Steps to test this PR _Feature 1_ - [x] Install from this branch. - [x] Open a few tabs. - [x] Search for something that matches the open tabs. Notice there's a divides between the top hits and search items. Notice there's a divider between the search items and the bottom section. - [x] Notice the quick insert icon is available only for search suggestions. - [x] Notice all URLs in suggestions don't have `http://www.`, `htps://www.`, `www.` as prefix and they don't have a trailing `/`. - [x] Notice that if you turn off the `autocompleteTabs` from `Feature Flag Inventory` you don't see the Switch to tab suggestions. ### UI changes | Divider dark node | Divider light mode | | ------ | ----- | |![divider_light_mode](https://github.com/user-attachments/assets/30802a7b-6936-46b2-9b79-56d3af1efc92)|![divider_dark_mode](https://github.com/user-attachments/assets/c2f277fc-7e9b-41f8-b6f9-938916c68034)| |No top divider | Bottom divider | | ------ | ----- | |![no_top_divider](https://github.com/user-attachments/assets/55467885-89d4-4e7d-82c4-2dbc8e41ecd6)|![bottom_divider](https://github.com/user-attachments/assets/1be711bf-c731-4379-90a9-f53c2995f914)|

…ggest (#5018) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208260875798966/f ### Description The full implementation will span across a few tasks. This is the main task for the implementation of [Android: Include existing open tabs in search autosuggest](https://app.asana.com/0/715106103902962/1208040193300233/f) ### Steps to test this PR See: - #5019 - #5042 - #5063 - #5064 - #5065 - #5105 - #5123 See scenarios and screenshots in https://app.asana.com/0/1200581511062568/1208264037618741/f --------- Co-authored-by: Dax The Translator <[email protected]>

This was referenced Sep 25, 2024

[Implementation] Android: Include existing open tabs in search autosuggest #5018

Merged

Include open tabs in the suggestions #5019

Merged

Handle clicks on "Switch to tab" #5042

Merged

Update algorithm to show the open tabs in the correct place #5063

Merged

anikiki mentioned this pull request Sep 25, 2024

Add pixels for open tabs in search autosuggest #5064

Merged

16 tasks

anikiki changed the title ~~Added translations.~~ Add translations for open tabs in search autosuggest Sep 25, 2024

anikiki added the STACKED PR - DO NOT MERGE label Sep 25, 2024

anikiki marked this pull request as ready for review September 25, 2024 16:59

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 1ecf111 to 328e2b4 Compare September 26, 2024 11:23

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 3f6cf64 to 17de826 Compare September 26, 2024 11:23

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 328e2b4 to 2491fda Compare September 26, 2024 11:45

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from b1f4598 to de8298f Compare September 26, 2024 11:45

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 2491fda to e18e755 Compare September 26, 2024 12:10

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from de8298f to 29e54bb Compare September 26, 2024 12:10

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from e18e755 to 6fbc6f3 Compare September 26, 2024 12:12

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 29e54bb to 0994f2e Compare September 26, 2024 12:12

CrisBarreiro approved these changes Sep 26, 2024

View reviewed changes

This was referenced Oct 8, 2024

Address the tasks in the Meta section #5105

Merged

Android: Migrate auto-complete to Flow and Coroutines #5123

Merged

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 6fbc6f3 to 880ec9e Compare October 10, 2024 15:29

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 1ee6d24 to 12256db Compare October 10, 2024 15:29

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 880ec9e to c2fd1de Compare October 10, 2024 15:39

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from c46cf24 to 5d0ed05 Compare October 10, 2024 15:39

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from c2fd1de to 3abd869 Compare October 10, 2024 15:45

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from 5d0ed05 to 871743c Compare October 10, 2024 15:45

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from 3abd869 to e159b67 Compare October 11, 2024 16:07

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from e62d927 to 26275f2 Compare October 11, 2024 16:07

anikiki assigned CrisBarreiro Oct 14, 2024

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from e159b67 to bc72676 Compare October 18, 2024 12:10

daxmobile added 21 commits October 21, 2024 16:14

Translate strings to values-hu

589543b

Translate strings to values-sk

477b6ac

Translate strings to values-pt

d255578

Translate strings to values-ro

d2ee6e6

Translate strings to values-es

b4c4406

Translate strings to values-ru

Translate strings to values-et

0c609ff

Translate strings to values-sv

5efc940

Translate strings to values-da Translate strings to values-cs

Translate strings to values-fi

e4c09e7

Translate strings to values-fr

Translate strings to values-nl

49eb2d4

Translate strings to values-lt

Translate strings to values-lv

fec254e

Translate strings to values-bg

b4e1c05

Translate strings to values-it

f85edfe

Translate strings to values-tr

3c04bee

Translate strings to values-nb

c97fa89

Translate strings to values-de

8e67527

Translate strings to values-el

3bb159b

Translate strings to values-pl

cda832b

anikiki force-pushed the feature/ana/add_pixels_for_open_tabs_in_search_autosuggest branch from bc72676 to 82707b3 Compare October 21, 2024 15:15

anikiki force-pushed the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch from e65d5a4 to f7a8db6 Compare October 21, 2024 15:15

This was referenced Oct 21, 2024

Bug: autocomplete pixels firing when Adding Bookmark #5165

Merged

Bug: Unable to delete autocomplete history items #5168

Merged

anikiki merged commit d2c56c7 into feature/ana/add_pixels_for_open_tabs_in_search_autosuggest Oct 22, 2024
4 checks passed

anikiki deleted the feature/ana/add_translations_for_open_tabs_in_search_autosuggest_l10n branch October 22, 2024 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add translations for open tabs in search autosuggest #5065

Add translations for open tabs in search autosuggest #5065

anikiki commented Sep 25, 2024 •

edited by CrisBarreiro

Loading

anikiki commented Sep 25, 2024 •

edited

Loading

CrisBarreiro left a comment

Add translations for open tabs in search autosuggest #5065

Add translations for open tabs in search autosuggest #5065

Conversation

anikiki commented Sep 25, 2024 • edited by CrisBarreiro Loading

Description

Steps to test this PR

UI changes (Added Switch to Tab string)

anikiki commented Sep 25, 2024 • edited Loading

CrisBarreiro left a comment

Choose a reason for hiding this comment

anikiki commented Sep 25, 2024 •

edited by CrisBarreiro

Loading

anikiki commented Sep 25, 2024 •

edited

Loading