Update algorithm to show the open tabs in the correct place #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
4 tasks
anikiki
changed the title
This was referenced Sep 25, 2024
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
7c832f6 to
c584008
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
2a01940 to
b7105cf
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
c584008 to
717d20a
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
2 times, most recently
from
2ee8aac to
bdf3526
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
ec962a9 to
21cda6f
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
bdf3526 to
bdd704e
Compare
This was referenced Oct 8, 2024
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
21cda6f to
39a2206
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
bdd704e to
72671a1
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
39a2206 to
7210dda
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
72671a1 to
e19f6c8
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
7210dda to
f929c92
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
25144d4 to
673212b
Compare
CrisBarreiro
approved these changes
Oct 15, 2024
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
f929c92 to
322af6b
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
673212b to
9ba4a97
Compare
anikiki
force-pushed
the
feature/ana/handle_clicks_on_switch_to_tab
branch
from
322af6b to
bf286af
Compare
anikiki
force-pushed
the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
from
9ba4a97 to
24d6f50
Compare
This was referenced Oct 21, 2024
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208283215616231/f ### Description Added pixels. ### Steps to test this PR - [x] Install from this branch. - [x] Filter logcat by `m_autocomplete_click_switch_to_tab | m_autocomplete_displayed_switch_to_tab`. - [x] Navigate to `https://www.wikipedia.org`. - [x] Open another tab. - [x] Type `wiki. - [x] Notice the first suggestion is the open tab. - [x] Tap on the suggestion. - [x] Notice in the logs (2 pixels sent with the correct params -> `switch_to_tab_capable=true`, `showed_switch_to_tab=true`): `Pixel sent: m_autocomplete_displayed_switch_to_tab with params: {} {}` `Pixel sent: m_autocomplete_click_switch_to_tab with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=false, switch_to_tab_capable=true, showed_switch_to_tab=true} {}` - [x] Open another tab. - [x] Type `duck`. - [x] Tap on the first search suggestion. Notice nothing in the logs with the initial filter. - [x] Filter logcat by `showed_switch_to_tab`. - [x] Notice in the logs: `Pixel sent: m_autocomplete_click_phrase with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=false, switch_to_tab_capable=true, showed_switch_to_tab=false} {}` - [x] Close all tabs. - [x] Open a new tab and type `duck`. - [x] Tap on the first search suggestion and notice in logs: `Pixel sent: m_autocomplete_click_phrase with params: {sb=false, sf=false, bc=false, fc=false, hc=true, sh=true, switch_to_tab_capable=false, showed_switch_to_tab=false} {}` ### NO UI changes --------- Co-authored-by: Dax The Translator <[email protected]>
anikiki
merged commit ae96cc6
into
feature/ana/handle_clicks_on_switch_to_tab
4 checks passed
anikiki
deleted the
feature/ana/update_algorithm_to_show_the_open_tabs_in_the_correct_place
branch
anikiki
added a commit
that referenced
this pull request
Oct 25, 2024
…ggest (#5018) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208260875798966/f ### Description The full implementation will span across a few tasks. This is the main task for the implementation of [Android: Include existing open tabs in search autosuggest](https://app.asana.com/0/715106103902962/1208040193300233/f) ### Steps to test this PR See: - #5019 - #5042 - #5063 - #5064 - #5065 - #5105 - #5123 See scenarios and screenshots in https://app.asana.com/0/1200581511062568/1208264037618741/f --------- Co-authored-by: Dax The Translator <[email protected]>
aitorvs
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ggest (#5018) Task/Issue URL: https://app.asana.com/0/1200581511062568/1208260875798966/f ### Description The full implementation will span across a few tasks. This is the main task for the implementation of [Android: Include existing open tabs in search autosuggest](https://app.asana.com/0/715106103902962/1208040193300233/f) ### Steps to test this PR See: - #5019 - #5042 - #5063 - #5064 - #5065 - #5105 - #5123 See scenarios and screenshots in https://app.asana.com/0/1200581511062568/1208264037618741/f --------- Co-authored-by: Dax The Translator <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200581511062568/1208264037618748/f
Description
Updated the autosuggest algorithm to include open tabs.
Steps to test this PR
Feature 1
NO UI changes