Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version 1 #2130

Closed
wants to merge 784 commits into from
Closed

feat: version 1 #2130

wants to merge 784 commits into from

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Jun 18, 2024

Changes:

CSS:

  • Changed prefix from fds to ds on classes and layers
  • Font shorthand removed in favor of font classes
  • Changed focus styling
  • Added support for color modes with data-ds-color-mode="light/dark/auto". light is default
  • Added support for typography modes with data-ds-typography="primary/secondary". primary is default.
  • Radio: New checked style

React:

  • Removed old sizes
  • Button:
    • Removed success color
    • Replaced colors first and second with accent & neutral
  • Tag: Replaced colors first, second, third with brand1, brand2, brand3
  • Tooltip:
    • portal is now false by default
    • Removed inverted prop. Use data-ds-color-mode
  • Link:
    • Removed inverted prop. Use data-ds-color-mode
    • Added color prop with accent & neutral
  • Combobox: Fix issues with virtualization crashing
  • Accordion:
    • Rename AccordionHeader to AccordionHeading
    • Change Accordion to Accoridon.Root
  • Tabs: Change Tabs to Tabs.Root
  • ToggleGroup: Change ToggleGroup to ToggleGroup.Root
  • Popover: Change Popover to Popover.Root
  • DropdownMenu: Change DropdownMenu to DropdownMenu.Root
  • Modal: Remove Modal, Modal.Root is now always required
  • Paragraph: Added default variant
  • Search: Remove error
  • Alert: Remove elevated
  • Export useSynchronizedAnimation
  • Export useIsomorphicLayoutEffect
  • Export useMediaQuery
  • Export RovingFocusRoot
  • Export RovingFocusItem

Theme:

  • Completely new CSS variables.
  • Changed prefix from --fds to --ds on CSS variables.

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Preview deployments for this pull request:

📖 Storybook 6. Aug 2024 - 08:39 (Norwegian time)

🖥 Storefront 6. Aug 2024 - 08:40 (Norwegian time)

See all deployments at https://dev.designsystemet.no

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 70fea86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions bot and others added 7 commits August 21, 2024 08:49
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to next, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`next` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `next`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @digdir/[email protected]

### Minor Changes

- Update init script to new design-tokens format
([#2255](#2255))

## @digdir/[email protected]

### Minor Changes

- SkipLink: New style
([#2260](#2260))

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Table: Width is now by default `100%`
([#2285](#2285))

- AccordionHeading: Correct name on types
([#2276](#2276))

## @digdir/[email protected]

### Patch Changes

- Table: New hover prop and class for toggling hover on rows
([#2285](#2285))

- Combobox: Make controlled input adhere to `inputValue` and send all
change events
([#2267](#2267))

- AccordionHeading: Correct name on types
([#2276](#2276))

- Badge: Export component
([#2297](#2297))

- ToggleGroup, Tabs: Active item equality check is now strict
([#2253](#2253))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Fixes #2315

---------

Co-authored-by: Tobias Barsnes <[email protected]>
sets the `metadataBase` so it is not always using localhost.
fixes width on blog header images
Resolves #2222 

✋🏻🛑 Should not be published on desigystemet.no before the articles is
published on uxnorge.no (End of august).

Thanks to @sorensensig and @indiamaydesign for contributing 🙏🏻❤️
resolves #2269

Use theme-builder to select desired colors
<img width="1440" alt="image"
src="https://github.com/user-attachments/assets/42828ba6-76cf-4989-b835-5b369c29f42f">

Paste provided cli command in a terminal to generate desired
design-tokens
<img width="1238" alt="image"
src="https://github.com/user-attachments/assets/be61c86d-a62e-480b-b1d3-ec7fdb014b41">
Barsnes and others added 28 commits October 31, 2024 16:13
resolves #2696

This PR makes `hideLabel` work weird in some form components. This will
be looked at when we refactor these, as this has not been done yet. The
position relative we added makes our `sr-only` class not set its
position absolute.
Change meda query for breadcrumbs. Allow coverage for all view ports.
Including values between 650px and 651px
- Created new `Field.Counter` to replace `CharacterCounter`
- Will delete old `CharacterCounter` in #2710 when use is replaced with
`Field.Counter` there
- [Example
story](https://pr-2717.storybook.designsystemet.no/?path=/story/komponenter-field--counter)

---------

Co-authored-by: Eirik Backer <[email protected]>
resolves #2630

---------

Co-authored-by: barsnes <[email protected]>
Co-authored-by: Michael Marszalek <[email protected]>
…2736)

- Fixed `rootDir`, so the tsc output is no longer
`<outDir>/packages/cli/...`
- Set output of type declarations to be the same as the ESM build, so we
no longer require a separate `"types"` field in `package.json`
part of #2311

New API:
```tsx
  <Search>
    <Search.Input aria-label='Søk' />
    <Search.Clear />
    <Search.Button /> /* can be removed to get a simple variant */
  </Search>
```

---------

Co-authored-by: Eirik Backer <[email protected]>
We will make a separate PR where we can typecheck everything at once in
one workflow.
Expose native `event` in Modal `onClose` handler
- fix a missed update of `Search` after new component api was
introduced.
- fix renegade search and replace for `data-data-size`
resolves #2597
resolves #2598

---------

Co-authored-by: Eirik Backer <[email protected]>
resolves #2713

- Adds `DefaultProps` to `Field`
- Adds `counter` which takes a `number` or `FieldCounterProps`
- Kept `error` as we can look at this vs changes in `ValidationMessage`
later
- Will look closer at affix in #2748

---------

Co-authored-by: barsnes <[email protected]>
- Moves default background to `<body>` element instead of `:root` to
align with best practice and avoid conflicts when setting both
background on body and :root
- Fixes minor sizing issue on stories with custom css
The theme builder and Figma plugin have been changed to support the new
CLI options format that is necessary to support arbitrary number and
names for colors. However, unlike the CLI they are still hard-coded to
create and accept only the colors *accent, neutral, brand1, brand2* and
*brand3*
resolves #2732

- Updated readmes with simple documentation
Fix vite complaining about missing random cache files from storybook. 

<img width="1212" alt="image"
src="https://github.com/user-attachments/assets/6e135cd5-88cd-4c04-a243-41a1b27baeff">
On smaller screens the video and text may overflow outside of the
screen. To
handle this add some breakpoints to contain those elements in.

---------

Co-authored-by: Michael Marszalek <[email protected]>
This is a fork from #2712, and will be implemented further here.

---------

Co-authored-by: eirikbacker <[email protected]>
Co-authored-by: Eirik Backer <[email protected]>
Co-authored-by: Michael Marszalek <[email protected]>
@mimarz
Copy link
Collaborator Author

mimarz commented Nov 13, 2024

closing this as its currently eating up chromatic snapshots and we will have changesets release PR for v1 when the time comes

@mimarz mimarz closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants