Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move base-sizing and base-spacing should be moved to core #1775

Closed
2 tasks
Febakke opened this issue Apr 8, 2024 · 2 comments
Closed
2 tasks

Move base-sizing and base-spacing should be moved to core #1775

Febakke opened this issue Apr 8, 2024 · 2 comments
Assignees
@Febakke
Labels
$ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme

Comments

@Febakke
Copy link
Member

Febakke commented Apr 8, 2024

We dont need the base sizing values exposed in Figma as variables. If possible we should move them into the core set

  • Decide if we should do this
  • Move tokens
@Febakke Febakke added the $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme label Apr 8, 2024
@github-project-automation github-project-automation bot moved this to 🔵 Inbox in Team Design System Apr 8, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Apr 9, 2024
@mimarz
Copy link
Collaborator

mimarz commented Apr 9, 2024

This needs to be done after #1696

@mimarz
Copy link
Collaborator

mimarz commented Jun 28, 2024

This was solved in #2130

@mimarz mimarz closed this as completed Jun 28, 2024
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Febakke Febakke

Labels
$ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme
Projects
Team Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mimarz @Febakke