Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox - Clear selected input #2022

Closed
TobiasHansen opened this issue May 16, 2024 · 4 comments
Closed

Combobox - Clear selected input #2022

TobiasHansen opened this issue May 16, 2024 · 4 comments
Assignees
Labels
💡feature request react @digdir/designsystemet-react

Comments

@TobiasHansen
Copy link

Description

The clearing option is disabled if the Combobox is not being used as multiple. We have a form where we need our users to being able to clear a selected value, current workaround is to have a clear button beside the Combobox, but I would like the UI to be consistent between all Comboboxes used in the form.

I see that different design systems does this does this differently, some allows it (like Aksel ), and some doesnt.

My proposal is to make it possible to clear the value, but if that is not desirable then I would like to be able to send in a custom InputField to extend the component ourself.

Additional Information

No response

@mimarz
Copy link
Collaborator

mimarz commented Jun 18, 2024

Thanks for requesting this feature!

Things have been abit busy, but we'll have a look at this.

First of we are thinking of testing this with always having the clear buttons visible when a value is selected in both single and multiple mode.

We'll have a feature out for testing on next soonish :)

@mimarz mimarz added the react @digdir/designsystemet-react label Jun 18, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Jun 18, 2024
@Barsnes
Copy link
Member

Barsnes commented Jul 2, 2024

I have added this in #2130, but has not yet been pushed to the next tag.
You can test this on https://next.storybook.designsystemet.no/

@Barsnes Barsnes self-assigned this Jul 2, 2024
@Barsnes Barsnes moved this from 📄 Todo to 🏗 In progress in Team Design System Jul 2, 2024
@mimarz
Copy link
Collaborator

mimarz commented Jul 31, 2024

Hey @TobiasHansen!

We have released this under the next tag along with some other improvements.

Please test them and let us know 🤞

@TobiasHansen
Copy link
Author

@mimarz Sorry for the late response, thanks, works great now!

@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡feature request react @digdir/designsystemet-react
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants