58745 Switch to optional fields for va-medical-records page #775
+35
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
christinec-fftc
requested review from
aurora-a-k-a-lightning,
sethdarragile6,
navaeddie and
mchae-nava
10 tasks
mchae-nava
approved these changes
Jun 14, 2023
sethdarragile6
approved these changes
Jun 14, 2023
8 tasks
|
We discovered that these newly optional fields are required in EVSS. Do not proceed with this PR until after EVSS has made corresponding changes. Currently scheduled for 7/12/23. |
christinec-fftc
force-pushed
the
dbex/58745-vamc-optional
branch
from
568ca20 to
dab7f1b
Compare
Closed
10 tasks
|
Putting this into draft. We discovered that additional schema changes and possibly back end changes will be needed to support the optional fields. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| city: { | ||
| type: 'string', | ||
| maxLength: 30, | ||
| pattern: "^([-a-zA-Z0-9'.#]([-a-zA-Z0-9'.# ])?)*$", |
Check failure
Code scanning / CodeQL
Inefficient regular expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify schema for 526 EZ vaTreatmentFacilities
The following fields should now be optional on the va-medical-records page in 526
Related issues:
department-of-veterans-affairs/va.gov-team#60578
department-of-veterans-affairs/va.gov-team#58745
Pull Requests to update the schema in related repositories
We're hoping to merge this pr and the following 2 pr's all around the same time.
department-of-veterans-affairs/vets-website#24945
department-of-veterans-affairs/vets-api#12996