Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58745 VAMC updates #24549

Merged
merged 3 commits into from
Jun 20, 2023
Merged

58745 VAMC updates #24549

merged 3 commits into from
Jun 20, 2023

Conversation

christinec-fftc
Copy link
Contributor

@christinec-fftc christinec-fftc commented Jun 13, 2023

Summary

-Remove text and update text on the va-medical-records page
-Make the Name of VA medical facility input field free form instead of autosuggest from pre-defined list
-Cleanup unused code

Related issue(s)

department-of-veterans-affairs/va.gov-team#58745

Testing done

  • Describe what the old behavior was prior to the change
    Prior to this change the facility name was using auto suggest, but users would get stuck here since the api is not working

  • Describe the steps required to verify your changes are working as expected

  1. Start fllling out an original claim
  2. When you get to the supporting-evidence/evidence-types page, select 'VA medical records' for evidence types. Continue to the next page
  3. Verify you can type in a facility name, other required fields and then save or continue
    Note : the behavior of the array list component is to do a scroll up when clicking the save button (it will not collapse until you click 'Add another facility' button)
  4. Complete the rest of the 526 form and verify you can submit successfully
  • Describe the tests completed and the results
    Manual: created and submitted (original) claims with both new and rated conditions
    Unit: minor updates for unit tests
    e2e tests: verified all tests still working

Screenshots

image image

What areas of the site does it impact?

526EZ form on the va-medical-records page

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Copy link
Contributor

@mchae-nava mchae-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 201 to 202
// Treatment facility is missing a name, date, and city (they are optional). VSRs look at all VAMCs in the
// system to assess if it’s relevant to the claim.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the clarifying comment. This is pretty neat, and I'm curious how this check works. Definitely makes things so much more convenient for veterans

@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/58745-vamc-optional-fields/main June 16, 2023 16:39 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/dbex/58745-vamc-optional-fields/main June 16, 2023 16:39 In progress
@christinec-fftc christinec-fftc force-pushed the dbex/58745-vamc-optional-fields branch from 1c2e010 to 377f809 Compare June 16, 2023 22:28
@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/58745-vamc-optional-fields/main June 16, 2023 22:29 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/dbex/58745-vamc-optional-fields/main June 16, 2023 22:29 In progress
@christinec-fftc christinec-fftc changed the title 58745 VAMC optional fields 58745 VAMC updates Jun 20, 2023
@christinec-fftc christinec-fftc marked this pull request as ready for review June 20, 2023 22:02
@christinec-fftc christinec-fftc requested a review from a team June 20, 2023 22:02
@christinec-fftc christinec-fftc requested review from a team as code owners June 20, 2023 22:02
@christinec-fftc christinec-fftc merged commit c3e9b17 into main Jun 20, 2023
@christinec-fftc christinec-fftc deleted the dbex/58745-vamc-optional-fields branch June 20, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Fix - Changes for VAMC field in Supporting Evidence
5 participants