Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60578 make VA medical center fields optional #24945

Closed
wants to merge 2 commits into from

Conversation

christinec-fftc
Copy link
Contributor

@christinec-fftc christinec-fftc commented Jul 20, 2023

Summary

  • (Summarize the changes that have been made to the platform)
    Make 3 fields optional on the VA medical center page: treatment center name, disability names, country. We have learned that while these fields are helpful for processing a claim, they are not required. User should be able to submit 526 claim with no value or unvalidated value for these fields

These changes are dependent on vets-json-schema changes in department-of-veterans-affairs/vets-json-schema#775

  • (Which team do you work for, does your team own the maintenance of this component?)
    Disability Experience Team, yes

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
    n/a

Related issue(s)

Testing done

  • Describe what the old behavior was prior to the change
    These fields were previously required. User could not save the form until they had a valid value for each of them.

  • Describe the steps required to verify your changes are working as expected

  1. Start filling out an original claim
  2. When you get to the supporting-evidence/evidence-types page, select 'VA medical records' for evidence types.
  3. Continue to the next page
  4. Verify you can click the Continue button without filling out any fields. The facility name should be auto populated with 'Facility name not provided' when saving the empty form and also on the supporting-evidence/summary page
  5. As a regression, go back and add a new facility with all fields filled out. Verify you can see both items on the summary page
  6. Complete the rest of the 526 form and verify you can submit successfully
  • Describe the tests completed and the results
    Unit test has been updated to include saving empty form

Screenshots

image

image

What areas of the site does it impact?

21-526EZ

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vsp-bot va-vsp-bot requested a deployment to master/dbex/60578-vamc-optional-fields/main July 20, 2023 22:29 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex/60578-vamc-optional-fields/main July 20, 2023 22:30 Inactive
@christinec-fftc christinec-fftc linked an issue Jul 21, 2023 that may be closed by this pull request
16 tasks
Copy link

This PR is stale because it has been open 120 days with no activity. It will recieve a stale label every day for 14 days before being closed unless it recieves a comment or the stale label is removed.

@github-actions github-actions bot added the Stale label Nov 23, 2023
@github-actions github-actions bot closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make VAMC fields optional
3 participants