-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: URP update - replace obsolete RenderTargetHandle with new RTHandle #5562
Draft
pravusjif
wants to merge
18
commits into
dev
Choose a base branch
from
chore/URP-update-replace-RenderTargetHandle-with-RTHandle
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: URP update - replace obsolete RenderTargetHandle with new RTHandle #5562
pravusjif
wants to merge
18
commits into
dev
from
chore/URP-update-replace-RenderTargetHandle-with-RTHandle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th UberPost shader and with building process error
…into test/perf-profiling-unity2022.3.4f1
…om unity 2022.3.6f1
…Couldn't make Outline Screen Effect Feature to work...
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this branch uses the project with Unity version 2022.3.6f1
RenderTargetHandle
class as obsolete and commands to useRTHandle
instead, but several things work differently with that new class. With Unity 2022.3.6, URP 14.0.8 is used.RenderTargetHandle
usages to the newRTHandle
way and managed to avoid any runtime error but the outline screen effect (used for hovered avatars) is still not rendering anything...test/perf-profiling-unity2022.3.4f1
branch so that it only contains theRTHandle
file change replacements and is easily checked to continue this work in the futureMain problems found
cmd.GetTemporaryRT()
for some reason the targetRTHandle
doesn't get any render texture assigned (its.rt
property is null), and later when trying to useBlit()
with thatRTHandle
in runtime, we get aValue vannot be null
fatal error due to the.rt
property being null.RenderingUtils.ReAllocateIfNeeded()
instead ofcmd.GetTemporaryRT()
(as Unity does in many replacements on their own PR) we get a render texture assigned to the.rt
property (getting rid of the null error) but the Outline Screen Effect Feature still doesn't render the outline when hovering an avatar...Useful links as guidelines to continue this migration in the future
RenderTargetHandle
toRTHandle
PR: Unity-Technologies/Graphics@d48795e#diff-922e8cb79285d375cad88e469448eebfc9aac59f470810a027d6d70113ed6a4b