Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update unity project version to unity2022.3.6f1 #5663

Closed
wants to merge 37 commits into from

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Aug 30, 2023

  • Updated whole project from Unity 2021.3.22f1 LTS to Unity 2022.3.6f1 LTS
  • Updated UberPost shader based on URP 14.0.8. Re-applying our alpha value fix
  • Updated CharacterPreview prefab camera background color from white to black to improve avatars blending with the passport screen background
  • As per 2022.3.6f1 the annoying "FMOD errors" in the WebGL build should've gone away
  • Updated CI images used
  • Tried to replace the RenderTargetHandle usages (marked as obsolete since URP 13) with the new RTHandle class but couldn't get it to work. Since in URP 14.0.8 (the one used with Unity 2022.3) the old "obsolete" class still works, I'm leaving that implementation as it was. I created an informative draft PR to tackle that in the future, since probably that change will be mandatory to update the URP version further.

TESTING

This build should be tested as throroughly as a Release Candidate, and also adding:

  • Creating a new avatar from scratch as a guest
  • Creating a new avatar from scratch as a non-guest
  • Checking if the popular scenes work/look the same way as in production (ICE Poker scene, Wonder Mine, GolfCraft, any other scene that contains video playing)

TEST LINKS

pravusjif added 30 commits July 17, 2023 14:36
…th UberPost shader and with building process error
…into test/perf-profiling-unity2022.3.4f1
…into test/perf-profiling-unity2022.3.4f1
… black to improve avatars blending with background in passport screen
…into test/perf-profiling-unity2022.3.4f1
…into test/perf-profiling-unity2022.3.4f1
… if CI problem comes from cached libraries

Signed-off-by: Pravus <[email protected]>
…l to see if CI problem comes from cached libraries"

This reverts commit 8e8a23b.
@pravusjif pravusjif self-assigned this Aug 30, 2023
@pravusjif
Copy link
Member Author

Rendering bug found: with anti-aliasing disabled (as it is by default for any new user), some submeshes are invisible.

Reproduction steps

  1. Enter the onboarding world (https://play.decentraland.org/?explorer-branch=test/perf-profiling-unity2022.3.4f1&realm=dclonboarding.dcl.eth)
  2. Make sure anti-alising is off in explorer's graphic settings
  3. Notice that several tree cup submeshes are invisible
Screen Shot 2023-08-30 at 23 41 34

@pravusjif
Copy link
Member Author

Even after changing usages of DCL/Universal Render Pipeline/ shaders to the original ones from Unity, the bug still happens at the beginning. And these trees haven't been converted to AB so those are not cached Asset Bundles.

antialiasing.bug.mp4

@pravusjif
Copy link
Member Author

Also if Alpha Test keyword is commented-out from our custom shader, the problem stops happening... super weird.

But of course that breaks alpha testing (available through the SDK for materials)

@pravusjif pravusjif closed this Sep 6, 2023
@pravusjif pravusjif deleted the test/perf-profiling-unity2022.3.4f1 branch September 6, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant