Run action menu displays run metric based on graphql field instead of tag #24664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit fb8e0d3. |
mlarose
commented
Sep 23, 2024
mlarose
commented
Sep 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
mlarose
changed the title
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
ec2435b to
5a113df
Compare
mlarose
force-pushed
the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
from
a0b9774 to
c44e05b
Compare
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
5a113df to
60cdf38
Compare
mlarose
force-pushed
the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
2 times, most recently
from
51bbd4a to
fd50629
Compare
mlarose
changed the base branch from
mlarose/expose_enable_run_metrics_as_graphql_field
to
mlarose/run_metrics_hidden_tag_future_proofing
mlarose
force-pushed
the
mlarose/run_metrics_hidden_tag_future_proofing
branch
from
4b18021 to
3807049
Compare
mlarose
force-pushed
the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
2 times, most recently
from
882e669 to
c916d23
Compare
mlarose
force-pushed
the
mlarose/run_metrics_hidden_tag_future_proofing
branch
from
3807049 to
2351677
Compare
mlarose
force-pushed
the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
from
aad044f to
740e0f6
Compare
mlarose
requested review from
salazarm and
gibsondan
and removed request for
hellendag
gibsondan
approved these changes
Oct 8, 2024
| @@ -518,6 +516,7 @@ export const RUN_ACTIONS_MENU_RUN_FRAGMENT = gql` | |||
| repositoryName | |||
| repositoryLocationName | |||
| } | |||
| hasRunMetricsEnabled | |||
There was a problem hiding this comment.
uber nit, one could call this just 'runMetricsEnabled' ('has' and 'enabled' are arguably redundant)
mlarose
force-pushed
the
mlarose/run_metrics_hidden_tag_future_proofing
branch
from
2351677 to
710652d
Compare
mlarose
force-pushed
the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
from
5d35f90 to
d73e45a
Compare
mlarose
changed the base branch from
mlarose/run_metrics_hidden_tag_future_proofing
to
graphite-base/24664
Use the new GraphQL hasRunMetricsEnabled field created in #24662 to condition visibility of run metrics in action menu
mlarose
force-pushed
the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
from
d73e45a to
fb8e0d3
Compare
mlarose
deleted the
mlarose/dagit-uses-graphql-run-metrics-enabled-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Use the new graphql 'hasRunMetricsEnabled' field created in #24662 to condition visibility of run metrics in action menu
How I Tested These Changes
Changelog
NOCHANGELOG