feat: graphql add Run.hasRunMetricsEnabled field #24662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
gibsondan
approved these changes
Sep 24, 2024
python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py
Show resolved
Hide resolved
python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py
Outdated
Show resolved
Hide resolved
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
ec2435b to
5a113df
Compare
mlarose
changed the base branch from
mlarose/run_metrics_hidden_tag_future_proofing
to
mlarose/run-metrics-improvement
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py
Outdated
Show resolved
Hide resolved
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit 5a113df. |
mlarose
force-pushed
the
mlarose/run-metrics-improvement
branch
from
3eff5c2 to
e51900f
Compare
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
5a113df to
60cdf38
Compare
mlarose
force-pushed
the
mlarose/run-metrics-improvement
branch
from
e51900f to
d338339
Compare
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
60cdf38 to
ac750f9
Compare
mlarose
added a commit
that referenced
this pull request
Oct 7, 2024
Use the new GraphQL hasRunMetricsEnabled field created in #24662 to condition visibility of run metrics in action menu
mlarose
force-pushed
the
mlarose/run-metrics-improvement
branch
from
d338339 to
6c246bc
Compare
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
ac750f9 to
9f6cc7e
Compare
mlarose
added a commit
that referenced
this pull request
Oct 8, 2024
Use the new GraphQL hasRunMetricsEnabled field created in #24662 to condition visibility of run metrics in action menu
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 16514f6. |
mlarose
force-pushed
the
mlarose/run-metrics-improvement
branch
from
6c246bc to
29e1dc3
Compare
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
9f6cc7e to
61bff7c
Compare
mlarose
added a commit
that referenced
this pull request
Oct 8, 2024
Use the new GraphQL hasRunMetricsEnabled field created in #24662 to condition visibility of run metrics in action menu
mlarose
changed the base branch from
mlarose/run-metrics-improvement
to
graphite-base/24662
mlarose
force-pushed
the
mlarose/expose_enable_run_metrics_as_graphql_field
branch
from
61bff7c to
16514f6
Compare
mlarose
added a commit
that referenced
this pull request
Oct 8, 2024
Use the new GraphQL hasRunMetricsEnabled field created in #24662 to condition visibility of run metrics in action menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This change introduces a new field
hasRunMetricsEnabledto the GrapheneRun type in the GraphQL schema. It allows clients to query whether run metrics are enabled for a specific run. The implementation checks for the presence of run metric tags and their boolean values.This enables hiding the run metrics tag to declutter the frontend of this implementation detail.
How I Tested These Changes
Changelog
NOCHANGELOG