feat: View Container Metrics action visible based on new graphql field

Use the new GraphQL hasRunMetricsEnabled field created in #24662 to condition visibility of run metrics in action menu
dagster-io · Oct 8, 2024 · 88d2a17 · 88d2a17
1 parent 710652d
commit 88d2a17
Show file tree

Hide file tree

Showing 20 changed files with 43 additions and 27 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/client.json b/js_modules/dagster-ui/packages/ui-core/client.json
diff --git a/js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationTick.types.ts b/js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationTick.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/partitions/types/PartitionRunList.types.ts b/js_modules/dagster-ui/packages/ui-core/src/partitions/types/PartitionRunList.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineRunsRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineRunsRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunActionsMenu.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunActionsMenu.tsx
@@ -23,7 +23,6 @@ import {DeletionDialog} from './DeletionDialog';
 import {ReexecutionDialog} from './ReexecutionDialog';
 import {RunConfigDialog} from './RunConfigDialog';
 import {doneStatuses, failedStatuses} from './RunStatuses';
-import {DagsterTag} from './RunTag';
 import {RunTags} from './RunTags';
 import {RunsQueryRefetchContext} from './RunUtils';
 import {RunFilterToken} from './RunsFilterInput';
@@ -92,8 +91,7 @@ export const RunActionsMenu = React.memo(({run, onAddTag, anchorLabel}: Props) =
   const pipelineRun =
     data?.pipelineRunOrError?.__typename === 'Run' ? data?.pipelineRunOrError : null;
   const runConfigYaml = pipelineRun?.runConfigYaml;
-  const runMetricsEnabled = run.tags.some((t) => t.key === DagsterTag.RunMetrics);
-
+  const runMetricsEnabled = run.hasRunMetricsEnabled;
   const repoMatch = useRepositoryForRunWithParentSnapshot(pipelineRun);
   const jobError = useJobAvailabilityErrorForRun({
     ...run,
@@ -518,6 +516,7 @@ export const RUN_ACTIONS_MENU_RUN_FRAGMENT = gql`
       repositoryName
       repositoryLocationName
     }
+    hasRunMetricsEnabled
   }
 `;
 
@@ -537,6 +536,7 @@ export const PIPELINE_ENVIRONMENT_QUERY = gql`
           repositoryName
           repositoryLocationName
         }
+        hasRunMetricsEnabled
       }
     }
   }

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunFragments.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunFragments.tsx
@@ -17,6 +17,7 @@ export const RUN_FRAGMENT = gql`
     hasReExecutePermission
     hasTerminatePermission
     hasDeletePermission
+    hasRunMetricsEnabled
     status
     mode
     tags {

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunHeaderActions.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunHeaderActions.tsx
@@ -7,7 +7,6 @@ import {DeletionDialog} from './DeletionDialog';
 import {QueuedRunCriteriaDialog} from './QueuedRunCriteriaDialog';
 import {RunConfigDialog} from './RunConfigDialog';
 import {doneStatuses} from './RunStatuses';
-import {DagsterTag} from './RunTag';
 import {RunsQueryRefetchContext} from './RunUtils';
 import {TerminationDialog} from './TerminationDialog';
 import {RunFragment} from './types/RunFragments.types';
@@ -35,7 +34,7 @@ type VisibleDialog =
 
 export const RunHeaderActions = ({run, isJob}: {run: RunFragment; isJob: boolean}) => {
   const {runConfigYaml} = run;
-  const runMetricsEnabled = run.tags.some((t) => t.key === DagsterTag.RunMetrics);
+  const runMetricsEnabled = run.hasRunMetricsEnabled;
 
   const [visibleDialog, setVisibleDialog] = useState<VisibleDialog>(null);
 

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunTableRunFragment.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunTableRunFragment.tsx
@@ -11,6 +11,7 @@ export const RUN_TABLE_RUN_FRAGMENT = gql`
     hasReExecutePermission
     hasTerminatePermission
     hasDeletePermission
+    hasRunMetricsEnabled
     mode
     rootRunId
     parentRunId

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunTag.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunTag.tsx
@@ -33,7 +33,6 @@ export enum DagsterTag {
   SnapshotID = 'dagster/snapshot_id', // This only exists on the client, not the server.
   ReportingUser = 'dagster/reporting_user',
   User = 'user',
-  RunMetrics = 'dagster/run_metrics',
 
   // Hidden tags (using ".dagster" HIDDEN_TAG_PREFIX)
   RepositoryLabelTag = '.dagster/repository',

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/__fixtures__/RunActionsMenu.fixtures.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/__fixtures__/RunActionsMenu.fixtures.tsx
@@ -34,6 +34,7 @@ export const buildRunActionsMenuFragment = ({hasReExecutePermission}: RunConfigI
     canTerminate: true,
     hasDeletePermission: true,
     hasReExecutePermission,
+    hasRunMetricsEnabled: true,
     hasTerminatePermission: true,
     mode: 'default',
     rootRunId: 'abcdef12',

diff --git a/...s/dagster-ui/packages/ui-core/src/runs/__tests__/types/RunActionButtonsTestQuery.types.ts b/...s/dagster-ui/packages/ui-core/src/runs/__tests__/types/RunActionButtonsTestQuery.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunActionsMenu.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunActionsMenu.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunFragments.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunFragments.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunTableRunFragment.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunTableRunFragment.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsFeedRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsFeedRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsFeedRow.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsFeedRow.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/types/usePaginatedRunsTableRuns.types.ts b/js_modules/dagster-ui/packages/ui-core/src/runs/types/usePaginatedRunsTableRuns.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleRoot.types.ts b/js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleRoot.types.ts
diff --git a/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorPreviousRuns.types.ts b/js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorPreviousRuns.types.ts