Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run action menu displays run metric based on graphql field instead of tag #24664

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Run action menu displays run metric based on graphql field instead of tag #24664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
068e1bf
feat: View Container Metrics action visible based on new graphql field
mlarose Sep 23, 2024
fb8e0d3
regen graphql
mlarose Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions js_modules/dagster-ui/packages/ui-core/client.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/instigation/types/InstigationTick.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/partitions/types/PartitionRunList.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/pipelines/types/PipelineRunsRoot.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions js_modules/dagster-ui/packages/ui-core/src/runs/RunActionsMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {DeletionDialog} from './DeletionDialog';
import {ReexecutionDialog} from './ReexecutionDialog';
import {RunConfigDialog} from './RunConfigDialog';
import {doneStatuses, failedStatuses} from './RunStatuses';
import {DagsterTag} from './RunTag';
import {RunTags} from './RunTags';
import {RunsQueryRefetchContext} from './RunUtils';
import {RunFilterToken} from './RunsFilterInput';
Expand Down Expand Up @@ -92,8 +91,7 @@ export const RunActionsMenu = React.memo(({run, onAddTag, anchorLabel}: Props) =
const pipelineRun =
data?.pipelineRunOrError?.__typename === 'Run' ? data?.pipelineRunOrError : null;
const runConfigYaml = pipelineRun?.runConfigYaml;
const runMetricsEnabled = run.tags.some((t) => t.key === DagsterTag.RunMetrics);
mlarose marked this conversation as resolved.
Show resolved Hide resolved

const runMetricsEnabled = run.hasRunMetricsEnabled;
const repoMatch = useRepositoryForRunWithParentSnapshot(pipelineRun);
const jobError = useJobAvailabilityErrorForRun({
...run,
Expand Down Expand Up @@ -518,6 +516,7 @@ export const RUN_ACTIONS_MENU_RUN_FRAGMENT = gql`
repositoryName
repositoryLocationName
}
hasRunMetricsEnabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uber nit, one could call this just 'runMetricsEnabled' ('has' and 'enabled' are arguably redundant)

}
`;

Expand All @@ -537,6 +536,7 @@ export const PIPELINE_ENVIRONMENT_QUERY = gql`
repositoryName
repositoryLocationName
}
hasRunMetricsEnabled
}
}
}
Expand Down
1 change: 1 addition & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/RunFragments.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export const RUN_FRAGMENT = gql`
hasReExecutePermission
hasTerminatePermission
hasDeletePermission
hasRunMetricsEnabled
status
mode
tags {
Expand Down
3 changes: 1 addition & 2 deletions js_modules/dagster-ui/packages/ui-core/src/runs/RunHeaderActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {DeletionDialog} from './DeletionDialog';
import {QueuedRunCriteriaDialog} from './QueuedRunCriteriaDialog';
import {RunConfigDialog} from './RunConfigDialog';
import {doneStatuses} from './RunStatuses';
import {DagsterTag} from './RunTag';
import {RunsQueryRefetchContext} from './RunUtils';
import {TerminationDialog} from './TerminationDialog';
import {RunFragment} from './types/RunFragments.types';
Expand Down Expand Up @@ -35,7 +34,7 @@ type VisibleDialog =

export const RunHeaderActions = ({run, isJob}: {run: RunFragment; isJob: boolean}) => {
const {runConfigYaml} = run;
const runMetricsEnabled = run.tags.some((t) => t.key === DagsterTag.RunMetrics);
mlarose marked this conversation as resolved.
Show resolved Hide resolved
const runMetricsEnabled = run.hasRunMetricsEnabled;

const [visibleDialog, setVisibleDialog] = useState<VisibleDialog>(null);

Expand Down
1 change: 1 addition & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/RunTableRunFragment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const RUN_TABLE_RUN_FRAGMENT = gql`
hasReExecutePermission
hasTerminatePermission
hasDeletePermission
hasRunMetricsEnabled
mode
rootRunId
parentRunId
Expand Down
1 change: 0 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/runs/RunTag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export enum DagsterTag {
SnapshotID = 'dagster/snapshot_id', // This only exists on the client, not the server.
ReportingUser = 'dagster/reporting_user',
User = 'user',
RunMetrics = 'dagster/run_metrics',

// Hidden tags (using ".dagster" HIDDEN_TAG_PREFIX)
RepositoryLabelTag = '.dagster/repository',
Expand Down
1 change: 1 addition & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/__fixtures__/RunActionsMenu.fixtures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export const buildRunActionsMenuFragment = ({hasReExecutePermission}: RunConfigI
canTerminate: true,
hasDeletePermission: true,
hasReExecutePermission,
hasRunMetricsEnabled: true,
hasTerminatePermission: true,
mode: 'default',
rootRunId: 'abcdef12',
Expand Down
3 changes: 2 additions & 1 deletion ...s/dagster-ui/packages/ui-core/src/runs/__tests__/types/RunActionButtonsTestQuery.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/runs/types/RunActionsMenu.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/types/RunFragments.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/runs/types/RunRoot.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/types/RunTableRunFragment.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsFeedRoot.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/types/RunsFeedRow.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/runs/types/usePaginatedRunsTableRuns.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/schedules/types/ScheduleRoot.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/sensors/types/SensorPreviousRuns.types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.