Ensure api url setting has trailing slash

[soapy1]

Fixes #995

Description

This is required for the "log and artifact" links in the ui to work.

For example, follow the instructions in #995 to reproduce the issue. With this change, the links provided in the Logs and Artifacts section correctly point to /conda-store/api/v1/<rest of the api path>.

Pull request checklist

• Did you test this change locally?
• x Did you update the documentation (if required)?
• x Did you add/update relevant tests for this change (if required)?

[netlify]

✅ Deploy Preview for conda-store canceled.

Name	Link
🔨 Latest commit	f95db45
🔍 Latest deploy log	https://app.netlify.com/sites/conda-store/deploys/673fb7a23ca5780008995272

[soapy1]

I'm not sure if there is a better way to do this, like maybe on the ui side? The rest of the interactions between the ui and api seem to work properly with and without this change.

[peytondmurray]

Looks like this is not being tested, otherwise we would have caught this. Would it be possible to write a test to hit these logs/artifacts endpoints with and without trailing slashes?

[soapy1]

Would it be possible to write a test to hit these logs/artifacts endpoints with and without trailing slashes?

Thinking about this issue more, I think it would be better for this issue to be fixed in conda-store-ui opposed to conda-store.

The crux of the issue is that the logs/artifacts in the ui are links to some api endpoint. Without this slash the url_prefix is ignored for building these links. But, the rest of the api interactions between conda-store and conda-store-ui work without this trailing slash. So, that makes me think that there is an issue with how the ui is generating the links.

I took a quick look at the ui code, but I don't really understand how it works so I could be really off base here. @peytondmurray @gabalafou if you have some time could you take a look?

[soapy1]

ok so, I think this fixes things on the ui side conda-incubator/conda-store-ui#442 and this PR can be closed.

[gabalafou]

I think that the front-end app should be robust enough to handle whether an implementer supplies the base URL with or without the trailing slash

Hope you don't mind me closing this pull request in favor of conda-incubator/conda-store-ui#443.