Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - getting artifacts from the ui returns not found error #995

Open
soapy1 opened this issue Nov 20, 2024 · 1 comment · May be fixed by conda-incubator/conda-store-ui#443
Open

[BUG] - getting artifacts from the ui returns not found error #995

soapy1 opened this issue Nov 20, 2024 · 1 comment · May be fixed by conda-incubator/conda-store-ui#443
Assignees
Labels

Comments

@soapy1
Copy link
Contributor

soapy1 commented Nov 20, 2024

Describe the bug

conda-store's links to Logs and Artifacts for environment builds are incorrect. They point users to /api/v1/build/67/logs/, when they should point users to /<base path>/api/v1/build/67/logs/

As a result, when a user clicks one of these links, they get the result {"detail":"Not Found"} (since /api/v1/build/67/logs/ is not valid, /conda-store/api/v1/build/67/logs/ ).

Looks like this bug is maybe related to #932

Expected behavior

When you initiate a build thru the ui, some links to artifacts related to the build pop up at the bottom of the page. For example:
Image

When you click one of the links, conda-store should send a request to the /build/<build-id>/<> endpoint, for example http://localhost:8080/conda-store/api/v1/build/35/lockfile/. And then redirect to the object storage url, for example http://localhost:9000/conda-store/logs/db2456c0-1732135951-35-sdsd.log?...more args....
Image

How to Reproduce the problem?

Setup environment

  1. From the conda-store project
  2. Run docker compose up --build -d
  3. Wait for all the services to come up

Test out issue

  1. Create a new build in the ui (localhost:8080)
  2. Wait for the Logs and Artifacts section to be populated
  3. Click one of the links in the Logs and Artifacts section
  4. observe, the error message {"detail":"Not Found"} opposed to the logs or artifacts
    a. The url that is opened is /api/v1/build/67/logs/, but should be /conda-store/api/v1/build/67/logs/
@soapy1 soapy1 added the type: bug 🐛 Something isn't working label Nov 20, 2024
@soapy1 soapy1 moved this from New 🚦 to TODO 📬 in conda-store 🐍 Nov 20, 2024
@soapy1 soapy1 self-assigned this Nov 20, 2024
@soapy1 soapy1 moved this from TODO 📬 to In Progress 🏗 in conda-store 🐍 Nov 21, 2024
@gabalafou
Copy link
Contributor

I'm looking into this now. I have noticed both the backend (#997) and frontend (conda-incubator/conda-store-ui#442) PRs for this.

@soapy1 soapy1 moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In review 👀
2 participants