-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links to build artifacts #443
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this resolves the issue in conda-incubator/conda-store#995!
Calling out, I'm not very familiar with ts at all. Might be worth getting another reviewer?
Excellent! I was about to add instructions for how to confirm that this works, but you're already ahead of me. As for not being familiar with TypeScript, I think it's fine. I have made the tests much more comprehensive, so I think we can have confidence that this is working. And so long as the TypeScript checker isn't complaining (and there aren't any casts to |
Fixes:
Supersedes:
This is not the first time the build artifact links have been broken. The solution in this pull request is robust to both the recent breakage and the older one.