Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the unused Parameters #368

Closed
wants to merge 2 commits into from

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Nov 8, 2023

This is to drop unused parameters from the embedded MUR.Status.UserAccounts.Clusters type.

Related PRs
API - codeready-toolchain/api#387
Host-Operator - codeready-toolchain/host-operator#925

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fbm3307
Once this PR has been reviewed and has the lgtm label, please assign xcoulon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines -477 to -479
signupResponse.ConsoleURL = member.MemberStatus.Routes.ConsoleURL
signupResponse.CheDashboardURL = member.MemberStatus.Routes.CheDashboardURL
signupResponse.APIEndpoint = member.APIEndpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should stay there - these parameters are not from the MUR, but from MemberStatus.
In addition to that, we need to keep the signupResponse fields untouched - they are used by the clients.

We should only drop the fields from the MasterUserRecord.Status (as you did in the api PR) and make sure that these fields are not used anywhere. When you update the api dependency in the corresponding repos:

  • host-operator
  • registration-service
  • toolchain-common
  • toolchain-e2e

then you can easily check if the fields were used anywhere or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay got it

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

openshift-ci bot commented Nov 15, 2023

@fbm3307: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e a884ffb link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fbm3307
Copy link
Contributor Author

fbm3307 commented Nov 17, 2023

closing this PR as the changes are not required

@fbm3307 fbm3307 closed this Nov 17, 2023
@fbm3307 fbm3307 deleted the unusedparams branch November 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants