-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the unused Parameters #368
Conversation
Signed-off-by: Feny Mehta <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fbm3307 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
signupResponse.ConsoleURL = member.MemberStatus.Routes.ConsoleURL | ||
signupResponse.CheDashboardURL = member.MemberStatus.Routes.CheDashboardURL | ||
signupResponse.APIEndpoint = member.APIEndpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should stay there - these parameters are not from the MUR, but from MemberStatus.
In addition to that, we need to keep the signupResponse fields untouched - they are used by the clients.
We should only drop the fields from the MasterUserRecord.Status (as you did in the api PR) and make sure that these fields are not used anywhere. When you update the api dependency in the corresponding repos:
- host-operator
- registration-service
- toolchain-common
- toolchain-e2e
then you can easily check if the fields were used anywhere or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay got it
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@fbm3307: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
closing this PR as the changes are not required |
This is to drop unused parameters from the embedded MUR.Status.UserAccounts.Clusters type.
Related PRs
API - codeready-toolchain/api#387
Host-Operator - codeready-toolchain/host-operator#925