Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the unused Parameters #368

Closed
wants to merge 2 commits into from
Closed

Removing the unused Parameters #368

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05432aa
Removing the unused Parameters
fbm3307 Nov 8, 2023
a884ffb
Merge branch 'master' into unusedparams
mfrancisc Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/signup/service/signup_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,6 @@ func (s *ServiceImpl) DoGetSignup(ctx *gin.Context, provider ResourceProvider, u
signupResponse.ProxyURL = status.Status.HostRoutes.ProxyURL
for _, member := range status.Status.Members {
if member.ClusterName == mur.Status.UserAccounts[0].Cluster.Name {
signupResponse.ConsoleURL = member.MemberStatus.Routes.ConsoleURL
signupResponse.CheDashboardURL = member.MemberStatus.Routes.CheDashboardURL
signupResponse.APIEndpoint = member.APIEndpoint
Comment on lines -477 to -479
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should stay there - these parameters are not from the MUR, but from MemberStatus.
In addition to that, we need to keep the signupResponse fields untouched - they are used by the clients.

We should only drop the fields from the MasterUserRecord.Status (as you did in the api PR) and make sure that these fields are not used anywhere. When you update the api dependency in the corresponding repos:

  • host-operator
  • registration-service
  • toolchain-common
  • toolchain-e2e

then you can easily check if the fields were used anywhere or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay got it

signupResponse.ClusterName = member.ClusterName
break
}
Expand Down
Loading