-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping the unused parameters #387
Conversation
Signed-off-by: Feny Mehta <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... I wonder why there is no changes in api/v1alpha1/zz_generated.deepcopy.go
Don't you have that file changed after running make generate
?
Maybe because the deepcopy happens on whole struct and here i am just removing the parameters. ? |
Yeah.. probably because these fields are strings. Not structs. |
yup, I was looking at it too. The logic of the deepcopy is pretty generic and for the strings in the struct it's sufficient to just assign the whole value of the struct from the original one. |
Description
This is to Drop unused parameters from the embedded MUR.Status.UserAccounts.Clusters type
Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? yes/no
resources/setup/roles/host.yaml
in the sandbox-sre repositoryPROJECT
file: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSV
file: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.