Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping the unused parameters #387

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Nov 8, 2023

Description

This is to Drop unused parameters from the embedded MUR.Status.UserAccounts.Clusters type

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes

  3. In case of new CRD, did you the following? yes/no

  4. In case other projects are changed, please provides PR links.

Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I wonder why there is no changes in api/v1alpha1/zz_generated.deepcopy.go
Don't you have that file changed after running make generate?

@fbm3307
Copy link
Contributor Author

fbm3307 commented Nov 21, 2023

Hm... I wonder why there is no changes in api/v1alpha1/zz_generated.deepcopy.go Don't you have that file changed after running make generate?

Maybe because the deepcopy happens on whole struct and here i am just removing the parameters. ?
There were no changes to api/v1alpha1/zz_generated.deepcopy.go when i ran make generate.

@alexeykazakov
Copy link
Contributor

Yeah.. probably because these fields are strings. Not structs.

@MatousJobanek
Copy link
Contributor

Yeah.. probably because these fields are strings. Not structs.

yup, I was looking at it too. The logic of the deepcopy is pretty generic and for the strings in the struct it's sufficient to just assign the whole value of the struct from the original one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants