Use the streamlined ToolchainCluster and update its CRD.

[metlos]

Related PRs:

• api: Remove the deprecated ToolchainCluster.Spec fields api#448
• host-operator: Use the streamlined ToolchainCluster and update its CRD. #1094
• member-operator: Use the streamlined ToolchainCluster and update its CRD. member-operator#602
• registration-service: Use the streamlined ToolchainCluster. registration-service#474
• toolchain-e2e: Don't use the ToolchainCluster.Spec fields toolchain-e2e#1054
• ksctl: Don't use the deprecated fields in ToolchainCluster.Spec kubesaw/ksctl#84

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[metlos]

/retest

[metlos]

/retest

[metlos]

/retest

This seems environmental:

199. attempt (out of 200) of waiting for CRD memberoperatorconfigs.toolchain.dev.openshift.com to be available in the cluster and the InstallPlan to be complete
The installation takes suspiciously too long - deleting jobs. This may happen and is caused by flaky OLM installation.

[MatousJobanek]

@metlos this is not an environmental issue - it's failing that OLM cannot update ToolchainCluster CRD with the version. The problem is most likely the required spec.apiEndpoint field - it looks like that we need to make it optional first 🤦‍♂️

   status:
    bundleLookups:
    - catalogSourceRef:
        name: member-operator-c7c5a23
        namespace: toolchain-member-07140122
      identifier: toolchain-member-operator.v0.0.543-commit-c7c5a23
      path: quay.io/codeready-toolchain-test/member-operator-bundle:from.host-operator.PR1094.a749281
      properties: '{"properties":[{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"Workspace","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"MemberOperatorConfig","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"UserAccount","version":"v1alpha1"}},{"type":"olm.package","value":{"packageName":"toolchain-member-operator","version":"0.0.543-commit-c7c5a23"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"MemberStatus","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"ToolchainCluster","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"Idler","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"SpaceBindingRequest","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"NSTemplateSet","version":"v1alpha1"}},{"type":"olm.gvk","value":{"group":"toolchain.dev.openshift.com","kind":"SpaceRequest","version":"v1alpha1"}}]}'
      replaces: ""
    catalogSources:
    - member-operator-c7c5a23
    conditions:
    - lastTransitionTime: "2024-10-07T14:08:16Z"
      lastUpdateTime: "2024-10-07T14:08:16Z"
      message: 'error validating existing CRs against new CRD''s schema for "toolchainclusters.toolchain.dev.openshift.com":
        error validating toolchain.dev.openshift.com/v1alpha1, Kind=ToolchainCluster
        "toolchain-host-07140122/member-ci-op-qi3khbci-1de72.devsandboxci.devcluster.openshift.1":
        updated validation is too restrictive: [].spec.apiEndpoint: Required value'
      reason: InstallComponentFailed
      status: "False"
      type: Installed
    message: 'error validating existing CRs against new CRD''s schema for "toolchainclusters.toolchain.dev.openshift.com":
      error validating toolchain.dev.openshift.com/v1alpha1, Kind=ToolchainCluster
      "toolchain-host-07140122/member-ci-op-qi3khbci-1de72.devsandboxci.devcluster.openshift.1":
      updated validation is too restrictive: [].spec.apiEndpoint: Required value'
    phase: Failed 

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (7c011f6) to head (b388186).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   85.10%   85.08%   -0.02%     
==========================================
  Files          55       55              
  Lines        5041     5041              
==========================================
- Hits         4290     4289       -1     
- Misses        580      581       +1     
  Partials      171      171              

see 1 file with indirect coverage changes