Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ToolchainCluster.spec.apiEndpoint field #1096

Merged

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Oct 8, 2024

This is a continuation of #1094

Copy link

sonarqubecloud bot commented Oct 8, 2024

@openshift-ci openshift-ci bot added the approved label Oct 8, 2024
Copy link

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, metlos, mfrancisc, ranakan19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc,ranakan19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos metlos merged commit d58f8f7 into codeready-toolchain:master Oct 9, 2024
10 of 11 checks passed
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (c0c4242) to head (223adfd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
+ Coverage   85.08%   85.10%   +0.01%     
==========================================
  Files          55       55              
  Lines        5041     5041              
==========================================
+ Hits         4289     4290       +1     
+ Misses        581      580       -1     
  Partials      171      171              

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants