Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the streamlined ToolchainCluster and update its CRD. #602

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Use the streamlined ToolchainCluster and update its CRD. #602

merged 4 commits into from
Oct 8, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Oct 2, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the approved label Oct 2, 2024
This was referenced Oct 2, 2024
Merged
Merged
Merged
Merged
@metlos
Merge remote-tracking branch 'upstream/master' into deprecate-tc-spec…
69bb0d9 
…-fields-contd

# Conflicts:
#	go.mod
#	go.sum
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos
Copy link
Contributor Author

metlos commented Oct 4, 2024

/retest

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (c7c5a23) to head (11c9da9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          28       28           
  Lines        2604     2604           
=======================================
  Hits         2176     2176           
  Misses        288      288           
  Partials      140      140

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metlos metlos merged commit cab033b into codeready-toolchain:master Oct 8, 2024
11 of 12 checks passed
metlos added a commit that referenced this pull request Oct 8, 2024
@metlos
Revert "Use the streamlined ToolchainCluster and update its CRD. (#602)"
54a891d 
This reverts commit cab033b.
@metlos metlos mentioned this pull request Oct 8, 2024
Closed
@metlos metlos deleted the deprecate-tc-spec-fields-contd branch October 8, 2024 15:37
@metlos metlos mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@xcoulon xcoulon xcoulon approved these changes

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@mfrancisc mfrancisc Awaiting requested review from mfrancisc mfrancisc is a code owner

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@metlos @xcoulon @alexeykazakov @MatousJobanek @openshift-merge-robot