Update to [email protected] #460
Conversation
.travis.yml
Outdated
| @@ -15,11 +15,11 @@ addons: | |||
| firefox: 'latest-esr' | |||
| cache: | |||
| directories: | |||
| - node_modules | |||
| - node_module | |||
|
Please refer to ciena-frost/ember-frost-core#480 (comment) |
|
Changes Unknown when pulling 0c7dbec on quincyle:master into ** on ciena-frost:master**. |
|
Changes Unknown when pulling 07b1acd on quincyle:master into ** on ciena-frost:master**. |
|
Approved |
| describe('Unit: frost-bunsen-input-select', function () { | ||
| // Quincy Le 2017-07-30 | ||
| // can't find injection service:ajax with ember-cli: 2.12.3 | ||
| describe.skip('Unit: frost-bunsen-input-select', function () { | ||
| setupComponentTest('frost-bunsen-input-select', { |
There was a problem hiding this comment.
Change this to
setupComponentTest('frost-bunsen-input-select', {
unit: true,
needs: ['service:ajax']
})
Then the service will be injected
There was a problem hiding this comment.
Already tried it with no luck.
There was a problem hiding this comment.
Turns out ember treats 'service:ajax' and 'service: ajax' differently. 'service:ajax' is the correct syntax.
package.json
Outdated
| "ember-frost-date-picker": "^7.1.0", | ||
| "ember-frost-demo-components": "^3.0.1", | ||
| "ember-frost-demo-components": "git://github.com/helloWorldCindy/ember-frost-demo-components.git#upgrade", |
There was a problem hiding this comment.
This can be updated to now use the published version 3.1.2
config/ember-try.js
Outdated
| bower: { | ||
| dependencies: { | ||
| 'ember': '~2.3.0' | ||
| 'ember': '~2.11.0' |
There was a problem hiding this comment.
This needs to be the setup for version 2.8
.travis.yml
Outdated
| env: | ||
| matrix: | ||
| - EMBER_TRY_SCENARIO=ember-2-8 | ||
| - EMBER_TRY_SCENARIO=default | ||
| - EMBER_TRY_SCENARIO=ember-2-11 |
There was a problem hiding this comment.
This needs to be running ember-2-8 instead.
There was a problem hiding this comment.
As we've discussed, in the previous version, Bunsen actually never gets run with ember: 2.8 (With ember-source not being set as null in config/ember-try, CI will always run against ember-source presented in package.json, which was ember: ~2.11.0). I tried to run it against ember: 2.8.0, but I'm seeing extra test failure. Since it never runs against 2.8, I won't bother to fix these tests at this moment.
|
Changes Unknown when pulling 53ba181 on quincyle:master into ** on ciena-frost:master**. |
|
Changes Unknown when pulling f7e1ab7 on quincyle:master into ** on ciena-frost:master**. |
| "ember-cli-chai": "^0.3.2", | ||
| "ember-cli-code-coverage": "0.3.11", | ||
| "ember-cli-dependency-checker": "^1.3.0", | ||
| "ember-cli-htmlbars-inline-precompile": "0.3.6", | ||
| "ember-cli-frost-blueprints": "^1.0.0", | ||
| "ember-cli-htmlbars-inline-precompile": "0.3.12", |
There was a problem hiding this comment.
Re-run the build that was successful before, with no code change, and got build error from latest ember-cli-htmlbars-inline-precompile that just released. Pin it to 0.3.12 until it gets fixed.
There was a problem hiding this comment.
This is most likely related to what is reported here: ciena-frost/ember-frost-core#488
| } | ||
| } | ||
| }, | ||
| { | ||
| name: 'ember-2-8', |
There was a problem hiding this comment.
This entry is not correct. Make sure this file is identical to all the other versions of this file used in related upgrades of other repos
There was a problem hiding this comment.
We had to do run on ember-2-8 instead of ember-lts-2.8 on this repo because there was a difference between those two releases that was causing failures in the build.
config/ember-try.js
Outdated
| }, | ||
| resolutions: { | ||
| 'ember': '~2.9.0' | ||
| 'ember': 'lts-2-12' |
There was a problem hiding this comment.
This can be updated to:
{
name: 'ember-lts-2.12',
npm: {
devDependencies: {
'ember-source': '~2.12.0'
}
}
},
There was a problem hiding this comment.
Missed that one. Thanks for the catch.
|
Approved |
|
Changes Unknown when pulling 7e56486 on quincyle:master into ** on ciena-frost:master**. |
|
Changes Unknown when pulling 7e56486 on quincyle:master into ** on ciena-frost:master**. |
|
Changes Unknown when pulling 7e56486 on quincyle:master into ** on ciena-frost:master**. |
This project uses semver, please check the scope of this pr:
CHANGELOG
[email protected]